Skip to content

Conversation

@mturley
Copy link
Collaborator

@mturley mturley commented Apr 17, 2020

For some reason, on my machine when running yarn install after #4076 was merged I was getting failures related to node-gyp trying to compile an old version of fsevents (1.2.4), which does not have prebuilt binaries available for macOS. yarn why fsevents found that the only reason we depend on fsevents@1.2.4 is because we're on an old version of react-scripts in packages/react-integration/demo-app-ts.

This PR bumps that version of react-scripts (which should have no real impact as long as integration tests still run), and yarn install no longer needs to compile fsevents on my machine. No more errors, and a faster install time :)

Thanks @redallen for the help troubleshooting this.

@mturley mturley requested a review from redallen April 17, 2020 20:18
Copy link
Contributor

@redallen redallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mturley for your patience! LGTM

@patternfly-build
Copy link
Collaborator

patternfly-build commented Apr 17, 2020

Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but the tests are failing

@mturley mturley force-pushed the chore/bump-react-scripts branch from 0ace107 to ebc0297 Compare April 23, 2020 19:34
@mturley
Copy link
Collaborator Author

mturley commented Apr 23, 2020

Just rebased and pushed a commit that should fix the build_demo_app CI failure, but I'm not sure why the test_jest_pf4 one was failing. Let's see what happens this time.

@mturley
Copy link
Collaborator Author

mturley commented Apr 23, 2020

Hm.

@mturley
Copy link
Collaborator Author

mturley commented Apr 24, 2020

@redallen bizarrely enough, I'm not able to locally reproduce the build failures CircleCI is showing here, and I am now able to install/build on the existing v4 branch perfectly fine (no longer seeing the node-gyp errors that led me to open this PR in the first place). Maybe we should just close this.. but I am thoroughly confused, would love to figure out wtf is happening.

@mturley
Copy link
Collaborator Author

mturley commented Apr 24, 2020

I'm just going to close this, things seem to be working fine now.

@mturley mturley closed this Apr 24, 2020
@mturley mturley deleted the chore/bump-react-scripts branch April 28, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants