Skip to content

chore(packages): Bump version of react-scripts used by demo-app-ts to prevent node-gyp errors on yarn install #4092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mturley wants to merge 3 commits into from
Closed

chore(packages): Bump version of react-scripts used by demo-app-ts to prevent node-gyp errors on yarn install #4092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f34252
Bump the version of react-scripts used by react-integration/demo-app-ts
mturley Apr 17, 2020
defab7e
Fix lint error in LoginPageDemo
mturley Apr 23, 2020
ebc0297
Update yarn.lock
mturley Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-integration/demo-app-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@types/react": "^16.8.0",
"@types/react-dom": "^16.8.0",
"@types/react-router-dom": "^4.3.1",
"react-scripts": "2.1.3",
"react-scripts": "^3.4.1",
"typescript": "^3.8.3"
},
"browserslist": [
Expand Down
15 changes: 8 additions & 7 deletions packages/react-integration/demo-app-ts/src/components/demos/LoginPageDemo/LoginPageDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
import * as React from 'react';
/* eslint-disable camelcase */
const brandImg = require('./images/brandImgColor.svg') as string;
const pfbg_1200 = require('./images/pfbg_1200.jpg');
const pfbg_768 = require('./images/pfbg_768.jpg');
const pfbg_768_2x = require('./images/pfbg_768@2x.jpg');
const pfbg_576 = require('./images/pfbg_576.jpg');
const pfbg_576_2x = require('./images/pfbg_576@2x.jpg');

import {
LoginFooterItem,
Expand All @@ -18,6 +11,14 @@ import {
} from '@patternfly/react-core';
import ExclamationCircleIcon from '@patternfly/react-icons/dist/js/icons/exclamation-circle-icon';

/* eslint-disable camelcase */
const brandImg = require('./images/brandImgColor.svg') as string;
const pfbg_1200 = require('./images/pfbg_1200.jpg');
const pfbg_768 = require('./images/pfbg_768.jpg');
const pfbg_768_2x = require('./images/pfbg_768@2x.jpg');
const pfbg_576 = require('./images/pfbg_576.jpg');
const pfbg_576_2x = require('./images/pfbg_576@2x.jpg');

/**
* Note: When using background-filter.svg, you must also include #image_overlay as the fragment identifier
*/
Expand Down
Loading