fix(wizard): remove old prop "isCompactNav" #4142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanforyou23
added
PF4
Breaking change 💥
Collaborator
|
PF4 preview: https://patternfly-react-pr-4142.surge.sh |
mcoker
approved these changes
Apr 28, 2020
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Very nice! Thanks @seanforyou23!
cc @nicolethoen not sure if this will create a conflict with #4140
dlabrecq
approved these changes
Apr 28, 2020
boaz0
approved these changes
Apr 29, 2020
nicolethoen
approved these changes
Apr 29, 2020
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #3686
Breaking changes
isCompactNav. This prop is no longer used.Additional issues: patternfly/patternfly#2936