Breaking/alert #4190
Merged
Breaking/alert #4190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschuler
commented
May 5, 2020
| import avatarImg from './examples/avatarImg.svg'; | ||
|
|
||
| <Avatar src={avatarImg} alt="avatar"></Avatar> | ||
| class AvatarExample extends React.Component { |
Collaborator
Author
There was a problem hiding this comment.
made this change because i noticed the codesandbox wasn't working before. should probably go through and update all the examples that use the previous syntax @redallen ?
Contributor
There was a problem hiding this comment.
All you need is to name the example like this @jschuler :
AvatarExample = () => <Avatar src={avatarImg} alt="avatar"></Avatar>
Collaborator
Author
There was a problem hiding this comment.
codesandbox would work (after adding const in front), but our docs would not
SyntaxError: Unexpected token (1:8)
1 : return (const AvatarExample = () => <Avatar src={avatarImg} alt="avatar"></Avatar>)
Collaborator
|
PF4 preview: https://patternfly-react-pr-4190.surge.sh |
dlabrecq
approved these changes
May 5, 2020
Member
dlabrecq
left a comment
dlabrecq
left a comment
There was a problem hiding this comment.
Tests failed for actionClose, but otherwise LGTM
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #4082
Alerts can now contain both the close button and one or more action links.
Breaking changes
actionprop for the close button, use theactionCloseprop insteadactionprop for a link button, use theactionLinksprop instead