fix(build): lint for breaking changes off v4 #4199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redallen
force-pushed
the
chore/fix-breaking-change-lint-v4
branch
from
49e0db2 to
ef12323
Compare
Collaborator
|
PF4 preview: https://patternfly-react-pr-4199.surge.sh |
redallen
requested review from
ddonahue007,
evwilkin,
jschuler,
kmcfaul and
tlabaj
kmcfaul
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Fixed failing builds since #4190 was merged 2 hours ago: https://circleci.com/gh/patternfly/patternfly-react/34192 https://circleci.com/gh/patternfly/patternfly-react/34126 .
Require lint to pass before publishing to be extra safe in preventing accidental major version bumps in the future.
Additional issues: