Skip to content

fix(build): lint for breaking changes off v4 #4199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redallen merged 1 commit into from
May 6, 2020
Merged

fix(build): lint for breaking changes off v4 #4199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ workflows:
- build_docs_pf4
- deploy_prerelease:
requires:
- lint_pf4
- test_jest_pf4
- test_integration
- build_docs_pf4
Expand Down Expand Up @@ -221,7 +222,7 @@ jobs:
name: Breaking Change Lint
# https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
command: |
if git log origin/master..HEAD --format="%b" | grep -i "breaking change";
if git log origin/${CIRCLE_BRANCH}..HEAD --format="%b" | grep -i "breaking change";
then
echo "Breaking change above detected"
exit 1
Expand Down