Skip to content

Conversation

@jschuler
Copy link
Collaborator

What: Closes #4253

@patternfly-build
Copy link
Collaborator

patternfly-build commented May 14, 2020

Copy link
Member

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #4254 into v4 will decrease coverage by 2.59%.
The diff coverage is 49.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4    #4254      +/-   ##
==========================================
- Coverage   57.85%   55.25%   -2.60%     
==========================================
  Files         391      426      +35     
  Lines        5979     7054    +1075     
  Branches     2354     2607     +253     
==========================================
+ Hits         3459     3898     +439     
- Misses       2064     2660     +596     
- Partials      456      496      +40     
Flag Coverage Δ
#patternfly4 55.25% <49.25%> (-2.60%) ⬇️
Impacted Files Coverage Δ
...ages/react-core/src/components/Page/PageHeader.tsx 72.72% <0.00%> (+6.06%) ⬆️
packages/react-core/src/components/Tabs/Tab.tsx 100.00% <ø> (ø)
...kages/react-core/src/components/Tabs/TabButton.tsx 83.33% <ø> (ø)
...eact-core/src/components/Toolbar/ToolbarFilter.tsx 8.00% <0.00%> (ø)
packages/react-core/src/helpers/util.ts 46.66% <ø> (ø)
...mponents/Table/utils/decorators/compoundExpand.tsx 90.00% <ø> (ø)
...-table/src/components/Table/utils/transformers.tsx 100.00% <ø> (ø)
packages/react-topology/src/utils/element-utils.ts 7.93% <ø> (ø)
packages/react-topology/src/utils/geom-utils.ts 16.66% <ø> (ø)
packages/react-topology/src/utils/svg-utils.ts 2.56% <ø> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05fe5cd...640be89. Read the comment docs.

Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit bb0f623 into patternfly:v4 May 14, 2020
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@4.2.38
  • @patternfly/react-core@4.14.1
  • @patternfly/react-docs@5.2.44
  • @patternfly/react-inline-edit-extension@4.3.39
  • demo-app-ts@4.10.1
  • @patternfly/react-table@4.3.39
  • @patternfly/react-topology@4.2.38
  • @patternfly/react-virtualized-extension@4.2.39

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update card demo with header tools items

8 participants