Skip to content

update card demo header tools #4254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 1 commit into from
May 14, 2020
Merged

update card demo header tools #4254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 69 additions & 16 deletions packages/react-core/src/demos/CardView/examples/CardView.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
CardBody,
Checkbox,
Dropdown,
DropdownGroup,
DropdownToggle,
DropdownItem,
DropdownSeparator,
Expand All @@ -31,6 +32,8 @@ import {
Page,
PageHeader,
PageHeaderTools,
PageHeaderToolsGroup,
PageHeaderToolsItem,
PageSection,
PageSectionVariants,
PageSidebar,
Expand All @@ -44,7 +47,7 @@ import {
ToolbarContent
} from '@patternfly/react-core';
import { css } from '@patternfly/react-styles';
import { BellIcon, CogIcon, FilterIcon, TrashIcon } from '@patternfly/react-icons';
import { BellIcon, CogIcon, FilterIcon, TrashIcon, HelpIcon } from '@patternfly/react-icons';
import imgBrand from '@patternfly/react-core/src/demos/PageLayout/examples/imgBrand.svg';
import imgAvatar from '@patternfly/react-core/src/demos/PageLayout/examples/imgAvatar.svg';
import pfIcon from './pf-logo-small.svg';
Expand Down Expand Up @@ -76,6 +79,7 @@ import {
CardBody,
Checkbox,
Dropdown,
DropdownGroup,
DropdownToggle,
DropdownItem,
DropdownSeparator,
Expand All @@ -91,6 +95,8 @@ import {
Page,
PageHeader,
PageHeaderTools,
PageHeaderToolsGroup,
PageHeaderToolsItem,
PageSection,
PageSectionVariants,
PageSidebar,
Expand All @@ -107,7 +113,7 @@ import {
ToolbarContent
} from '@patternfly/react-core';
import { css } from '@patternfly/react-styles';
import { BellIcon, CogIcon, FilterIcon, TrashIcon } from '@patternfly/react-icons';
import { BellIcon, CogIcon, FilterIcon, TrashIcon, HelpIcon } from '@patternfly/react-icons';
import imgBrand from '@patternfly/react-core/src/demos/PageLayout/examples/imgBrand.svg';
import imgAvatar from '@patternfly/react-core/src/demos/PageLayout/examples/imgAvatar.svg';
import pfIcon from './pf-logo-small.svg';
Expand Down Expand Up @@ -604,26 +610,73 @@ class CardViewBasic extends React.Component {
</Nav>
);

const userDropdownItems = [
<DropdownItem>Link</DropdownItem>,
<DropdownItem component="button">Action</DropdownItem>,
<DropdownItem isDisabled>Disabled Link</DropdownItem>,
<DropdownItem isDisabled component="button">
Disabled Action
const kebabDropdownItems = [
<DropdownItem>
<CogIcon /> Settings
</DropdownItem>,
<DropdownSeparator />,
<DropdownItem>Separated Link</DropdownItem>,
<DropdownItem component="button">Separated Action</DropdownItem>
<DropdownItem>
<HelpIcon /> Help
</DropdownItem>
];
const userDropdownItems = [
<DropdownGroup key="group 2">
<DropdownItem key="group 2 profile">My profile</DropdownItem>
<DropdownItem key="group 2 user" component="button">
User management
</DropdownItem>
<DropdownItem key="group 2 logout">Logout</DropdownItem>
</DropdownGroup>
];
const headerTools = (
<PageHeaderTools>
<PageHeaderToolsGroup breakpointMods={[{ modifier: 'hidden' }, { modifier: 'visible', breakpoint: 'lg' }]} /** the settings and help icon buttons are only visible on desktop sizes and replaced by a kebab dropdown for other sizes */>
<PageHeaderToolsItem>
<Button aria-label="Settings actions" variant={ButtonVariant.plain}>
<CogIcon />
</Button>
</PageHeaderToolsItem>
<PageHeaderToolsItem>
<Button aria-label="Help actions" variant={ButtonVariant.plain}>
<HelpIcon />
</Button>
</PageHeaderToolsItem>
</PageHeaderToolsGroup>
<PageHeaderToolsGroup>
<PageHeaderToolsItem breakpointMods={[{ modifier: 'hidden', breakpoint: 'lg' }]} /** this kebab dropdown replaces the icon buttons and is hidden for desktop sizes */>
<Dropdown
isPlain
position="right"
onSelect={this.onKebabDropdownSelect}
toggle={<KebabToggle onToggle={this.onPageToolbarKebabDropdownToggle} />}
isOpen={isUpperToolbarKebabDropdownOpen}
dropdownItems={kebabDropdownItems}
/>
</PageHeaderToolsItem>
<PageHeaderToolsItem breakpointMods={[{ modifier: 'hidden' }, { modifier: 'visible', breakpoint: 'md' }]} /** this user dropdown is hidden on mobile sizes */>
<Dropdown
isPlain
position="right"
onSelect={this.onPageDropdownSelect}
isOpen={isUpperToolbarDropdownOpen}
toggle={
<DropdownToggle
onToggle={this.onPageDropdownToggle}
>
John Smith
</DropdownToggle>
}
dropdownItems={userDropdownItems}
/>
</PageHeaderToolsItem>
</PageHeaderToolsGroup>
<Avatar src={imgAvatar} alt="Avatar image" />
</PageHeaderTools>
);

const Header = (
<PageHeader
logo={<Brand src={imgBrand} alt="Patternfly Logo" />}
headerTools={
<PageHeaderTools>
<Avatar src={imgAvatar} alt="Avatar image" />
</PageHeaderTools>
}
headerTools={headerTools}
showNavToggle
/>
);
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3309,10 +3309,10 @@
xmldoc "^1.1.2"
yargs "^15.0.2"

"@patternfly/patternfly@4.10.20":
version "4.10.20"
resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-4.10.20.tgz#8441b5f483faae6b6d18522eb1839de398869af3"
integrity sha512-LRc2E/FIrX8U0x2QGGoCsYVzizUB/cp2k6BUWjpVZZvwSBWkS/KGUDUIgdeAcYfNDPrLlCcPtIAigT8xyzxQOw==
"@patternfly/patternfly@4.10.21":
version "4.10.21"
resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-4.10.21.tgz#b725b62dc7c2c5936e531b6287c27993a0d15263"
integrity sha512-0SNCg2Hw1cw6zBfCib/er4ZduyiuU8mAAz1lAePw6aC5uxDSWyj8r5G7Kdho5xF5ItqJ+t6gE9kWQL3YRjmPIQ==

"@pieh/friendly-errors-webpack-plugin@1.7.0-chalk-2":
version "1.7.0-chalk-2"
Expand Down