Skip to content

Conversation

@zanewoodfin
Copy link
Contributor

  • deprecate visiblity prop in ToolbarItem, ToolbarContent, ToolbarGroup, and ToolbarToggleGroup
  • add visibility prop in ToolbarItem, ToolbarContent, ToolbarGroup, and ToolbarToggleGroup

fix #4501

deprecate visiblity prop and add visibility prop in ToolbarItem, Toolbar
Content, ToolbarGroup, and ToolbarToggleGroup

fix patternfly#4501
@patternfly-build
Copy link
Collaborator

patternfly-build commented Jul 15, 2020

@codecov-commenter
Copy link

Codecov Report

Merging #4555 into master will decrease coverage by 0.02%.
The diff coverage is 8.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4555      +/-   ##
==========================================
- Coverage   56.77%   56.75%   -0.03%     
==========================================
  Files         450      450              
  Lines        8098     8105       +7     
  Branches     2956     2966      +10     
==========================================
+ Hits         4598     4600       +2     
+ Misses       2937     2934       -3     
- Partials      563      571       +8     
Flag Coverage Δ
#patternfly4 56.75% <8.00%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...ages/react-core/src/components/Popover/Popover.tsx 43.75% <0.00%> (-0.40%) ⬇️
...react-core/src/components/Toolbar/ToolbarGroup.tsx 25.00% <0.00%> (-15.00%) ⬇️
...core/src/components/Toolbar/ToolbarToggleGroup.tsx 26.08% <0.00%> (-3.92%) ⬇️
...ages/react-core/src/components/Tooltip/Tooltip.tsx 50.00% <0.00%> (-1.17%) ⬇️
packages/react-core/src/helpers/Popper/Popper.tsx 4.70% <ø> (+0.40%) ⬆️
...act-core/src/components/Toolbar/ToolbarContent.tsx 53.33% <33.33%> (-5.00%) ⬇️
.../react-core/src/components/Toolbar/ToolbarItem.tsx 50.00% <33.33%> (-7.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f743d...25f7db6. Read the comment docs.

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏼‍♀️
Thank you for this!

@DaoDaoNoCode DaoDaoNoCode merged commit c23659e into patternfly:master Jul 15, 2020
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@4.4.27
  • @patternfly/react-core@4.31.4
  • @patternfly/react-docs@5.5.18
  • @patternfly/react-inline-edit-extension@4.5.26
  • demo-app-ts@4.22.7
  • @patternfly/react-table@4.11.6
  • @patternfly/react-topology@4.4.28
  • @patternfly/react-virtualized-extension@4.5.18

Thanks for your contribution! 🎉

@tlabaj
Copy link
Contributor

tlabaj commented Jul 15, 2020

This one went in prematurely. Repos are frozen and there are a couple of changes that are needed. I created a PR to revert the change. Can you please post another PR once changes have been reverted.

redallen pushed a commit that referenced this pull request Jul 16, 2020
zanewoodfin added a commit to zanewoodfin/patternfly-react that referenced this pull request Jul 17, 2020
jschuler pushed a commit that referenced this pull request Aug 3, 2020
* Revert "Revert "fix(Toolbar*): change spelling of visiblity prop (#4555)" (#4556)"

This reverts commit 1a221f8.

* docs(Toolbar*): add Toolbar visibility demos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toolbar: Add new prop with correct spelling "Visibility" to Toolbar Components

7 participants