-
Notifications
You must be signed in to change notification settings - Fork 377
fix(Toolbar*): change spelling of visiblity prop #4555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Toolbar*): change spelling of visiblity prop #4555
Conversation
deprecate visiblity prop and add visibility prop in ToolbarItem, Toolbar Content, ToolbarGroup, and ToolbarToggleGroup fix patternfly#4501
|
PF4 preview: https://patternfly-react-pr-4555.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #4555 +/- ##
==========================================
- Coverage 56.77% 56.75% -0.03%
==========================================
Files 450 450
Lines 8098 8105 +7
Branches 2956 2966 +10
==========================================
+ Hits 4598 4600 +2
+ Misses 2937 2934 -3
- Partials 563 571 +8
Continue to review full report at Codecov.
|
nicolethoen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦🏼♀️
Thank you for this!
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
|
This one went in prematurely. Repos are frozen and there are a couple of changes that are needed. I created a PR to revert the change. Can you please post another PR once changes have been reverted. |
…ternfly#4555)" (patternfly#4556)" This reverts commit 1a221f8.
fix #4501