Skip to content

fix(Toolbar*): change spelling of visiblity prop #4560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jschuler merged 2 commits into from
Aug 3, 2020
Merged

fix(Toolbar*): change spelling of visiblity prop #4560

jschuler merged 2 commits into from
Aug 3, 2020

Conversation

@zanewoodfin
Copy link
Contributor

@zanewoodfin zanewoodfin commented Jul 16, 2020

  • deprecate visiblity prop in ToolbarItem, ToolbarContent, ToolbarGroup, and ToolbarToggleGroup
  • add visibility prop in ToolbarItem, ToolbarContent, ToolbarGroup, and ToolbarToggleGroup

fix #4501

@patternfly-build
Copy link
Collaborator

patternfly-build commented Jul 16, 2020 •
edited
Loading

PF4 preview: https://patternfly-react-pr-4560.surge.sh
A11y report: https://patternfly-react-pr-4560-coverage.surge.sh

@zanewoodfin zanewoodfin force-pushed the fix-toolbar-visiblity branch from 25f7db6 to 1de1a4f Compare July 17, 2020 15:39
tlabaj
tlabaj requested changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please update the demo app to add the correctly spelt visibility prop.

@zanewoodfin
Copy link
Contributor Author

zanewoodfin commented Jul 22, 2020

Can you also please update the demo app to add the correctly spelt visibility prop.

@tlabaj The demo app does not seem to have any instances of the old, misspelled prop. Do you want me to create some sort of new example with it?

dlabrecq
dlabrecq previously approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, https://github.com/patternfly/patternfly-react/pull/4601/files fixes toolbar visiblity typos in UPGRADE-GUIDE.md

@tlabaj tlabaj mentioned this pull request Jul 28, 2020
Merged
kmcfaul
kmcfaul previously approved these changes Jul 29, 2020
View reviewed changes
@tlabaj
Copy link
Contributor

tlabaj commented Jul 30, 2020

@zanewoodfin yes. You should add the new prop and the old one as well to the demo the verify that the work as expected. The old prop should have been in the demo. Please test all breakpoints we have add a lot of issues where breakpoints were not working as expected.

@zanewoodfin zanewoodfin dismissed stale reviews from kmcfaul and dlabrecq via 8da5358 August 3, 2020 14:32
@zanewoodfin zanewoodfin requested a review from tlabaj August 3, 2020 15:28
tlabaj
tlabaj approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jschuler jschuler merged commit cc17bf2 into patternfly:master Aug 3, 2020
DaoDaoNoCode
DaoDaoNoCode approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@patternfly-build
Copy link
Collaborator

patternfly-build commented Aug 3, 2020

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@4.7.0
  • @patternfly/react-charts@6.8.0
  • @patternfly/react-core@4.36.0
  • @patternfly/react-docs@5.7.0
  • @patternfly/react-icons@4.6.0
  • @patternfly/react-inline-edit-extension@4.5.52
  • demo-app-ts@4.26.0
  • @patternfly/react-integration@4.26.0
  • @patternfly/react-styles@4.6.0
  • @patternfly/react-table@4.14.0
  • @patternfly/react-tokens@4.8.0
  • @patternfly/react-topology@4.4.54
  • @patternfly/react-virtualized-extension@4.5.42

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlabaj tlabaj tlabaj approved these changes

@dlabrecq dlabrecq dlabrecq left review comments

@kmcfaul kmcfaul kmcfaul left review comments

+2 more reviewers

@jschuler jschuler jschuler approved these changes

@DaoDaoNoCode DaoDaoNoCode DaoDaoNoCode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Toolbar: Add new prop with correct spelling "Visibility" to Toolbar Components

7 participants

@zanewoodfin @patternfly-build @tlabaj @jschuler @dlabrecq @DaoDaoNoCode @kmcfaul