Skip to content

fix typos #4601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tlabaj merged 1 commit into from
Aug 4, 2020
Merged

fix typos #4601

tlabaj merged 1 commit into from
Aug 4, 2020

Conversation

@tanvisau
Copy link
Contributor

@tanvisau tanvisau commented Jul 21, 2020 •
edited by tlabaj
Loading

Fix typos

towards #4501

@tanvisau
fix typos
d39d88e 
Fix typos
@patternfly-build
Copy link
Collaborator

patternfly-build commented Jul 21, 2020 •
edited
Loading

PF4 preview: https://patternfly-react-pr-4601.surge.sh
A11y report: https://patternfly-react-pr-4601-coverage.surge.sh

@tlabaj
Copy link
Contributor

tlabaj commented Jul 21, 2020

Can you link the issue in the description please. Thanks

@tanvisau tanvisau changed the title fix typos fix typos #4600 Jul 21, 2020
@tanvisau tanvisau changed the title fix typos #4600 fix typos Jul 21, 2020
@tanvisau
Copy link
Contributor Author

tanvisau commented Jul 21, 2020

Can you link the issue in the description please. Thanks

Thanks for the review.
I've linked it.

@ljmotta
Copy link
Contributor

ljmotta commented Jul 22, 2020

Hi @tanvisau ! I saw that you linked my issue on this PR, but I'm not sure if it was a mistake? My issue is a type problem 😶

dlabrecq
dlabrecq approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, there is another PR #4555 to change the prop name for toolbar. Although, this update does not appear to be part of those changes.

jenny-s51
jenny-s51 approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are fine, provided that we also can get a new PR up for the changes that were reverted in #4555! Per @tlabaj :

This one went in prematurely. Repos are frozen and there are a couple of changes that are needed. I created a PR to revert the change. Can you please post another PR once changes have been reverted.

@zanewoodfin can you put up another PR with the changes you made in #4555?

@tlabaj
Copy link
Contributor

tlabaj commented Jul 28, 2020

@jenny-s51 There is already a pr up for that change #4560
@tanvisau can you link to issue #4501 or open a new issue for this PR please.

@tlabaj tlabaj merged commit 1ed28f6 into patternfly:master Aug 4, 2020
@patternfly-build
Copy link
Collaborator

patternfly-build commented Aug 4, 2020

Your changes have been released in:

  • @patternfly/react-docs@5.7.4

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlabrecq dlabrecq dlabrecq approved these changes

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

+1 more reviewer

@jenny-s51 jenny-s51 jenny-s51 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tanvisau @patternfly-build @tlabaj @ljmotta @dlabrecq @jenny-s51 @kmcfaul