fix(select): make 100% width and fix button and badge position #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Deploy preview for pf-next ready! Built with commit d374099 |
Contributor
|
This is outside of the scope of this PR, but should the selector for this block https://github.com/patternfly/patternfly-next/blob/ecdb09577c4ed2fc462211cd4a425c454dfa2043/src/patternfly/components/Select/select.scss#L263-L266 be |
mcoker
reviewed
Mar 18, 2019
| {{else if @partial-block}} | ||
| <span class="pf-c-select__toggle-text">{{> @partial-block}}</span> | ||
| {{else}} | ||
| <span>Select</span> |
Contributor
There was a problem hiding this comment.
Can you fix the indentation in this file? Looks like it's using the wrong tab space value
Contributor
|
Looks great, left a couple of comments. |
Member
Author
|
@mcoker ready for another review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1539