Remove href from button to prevent possible navigation
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes paulirish#123 Better support for the progressive enhancement approach of making the play button a link before the custom element loads.
coliff
approved these changes
Apr 16, 2022
FANMixco
added a commit
to SupernovaIC/lite-youtube-embed
that referenced
this pull request
Aug 8, 2022
I combined two pull requests: - paulirish#124 - paulirish#122 - Added also support to WebP.
paulirish
changed the title
href from play button when element loadshref from button to prevent possible navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123
Better support for the progressive enhancement approach of making the play button a link before the custom element loads. Currently with that approach, clicking the play button will navigate to YouTube even after the custom element has loaded. This PR removes the link’s
hrefin theconnectedCallbackto stop that from happening.