Fix accessibility of progressive enhancement pattern #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
sorry.. i got distracted with @scottjehl's new PR that does the same thing: #183... I somewhat do prefer the diff in 183 though... That said, please holler if there's a behavior difference we need to address! |
also... what a delight that you have 2 PRs exactly 2 years apart:
April 11th is Annual lite-youtube PR Day! ❤️ |
|
Oh my, I hadn’t noticed — better mark my calendar for next year 😁 Happy to see this fixed 💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #124 I naïvely “fixed” the issue of the play button being a link when following the progressive enhancement pattern by removing the
hrefattribute.However, this introduced an accessibility issue:
<a>without anhrefattribute is considered non-interactive, and therefore can’t be tabbed to by keyboard users, preventing them from playing the video.This PR seeks to fix this more correctly by replacing an
<a>element entirely with a<button>when the custom element loads. This preserves interactive semantics.To test I loaded the progressive enhancement example. Before this change, the play button is not focusable with the keyboard. After this change, the play button can be focused as expected.