-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails after 1st run (Win7, v2.0.2) #121
Comments
Hello, thanks for the filling the issue. Reproducing localhost wouldn't help without having the source code of what you serve nor the method by which you serve it. For instance if your http server is a node process, to run pwmetrics it has to be on a separate process. Could you provide an example of a non-localhost site where I can reproduce this? Support for lighthouse v2 flags will be added with #119 yes |
Thanks for your quick reply @pedro93! Just tested with
As for localhost: I am serving it through browserSync which proxies a local Apache. |
That is very strange, I just ran pwmetrics on my machine (ubuntu) and it worked: The only variation I see is the operating system. I have a windows 8 machine at home, I will try there in a couple of hours. In the meantime could you see in the lighthouse repo if there are windows-related issues opened? Also could try to run lighthouse v2 from the command line and see if you get current output? This could be a windows-specific 1.6.5 lighthouse bug, if thats the case #119 will solve the problem when landed.. |
Hey guys. I assume that this problem can be present on windows and it could be related to chrome launcher. But it should work after updating to LH v2. I'll test current version and with LH v2 on windows later today. Will see how it goes. |
it seems related to this eh... |
@samccone FYI pwmetrics does not use lighthouse v2 yet. That is in a PR currently. Does the issue GoogleChrome/lighthouse#2337 also happens for lighthouse v1.6.5? If not this could be something else altogether. We use a commit specific version: paulirish/lighthouse#c74ea959" |
@samccone @pedro93 — thanks for looking into this! I assume — as GoogleChrome/lighthouse#2359 fixes the related LH v2.0.0 issue — we can expect this to be coming in with #119? |
Yes we intend to merge #119 as soon GoogleChrome/lighthouse#2251 is landed and published. |
The root issues was pre lighthouse 2 :) |
Should be fixed by #120 |
Running
pwmetrics http://localhost:3000/ --runs=3
fails after the first run.Steps to reproduce.
pwmetrics http://localhost:3000/ --runs=3
Stack trace
Environment
pwmetrics
version: 2.0.2I got similar errors on non-localhost sites. Doing just 1 run is fine.
Also: I've noticed the Chrome Translation Dialog pops up, possibly interfering with Lighthouse?
Current Lighthouse version supports
--disable-translate
but adding that flag does not seem to work. I assume support will be added with #119 ?The text was updated successfully, but these errors were encountered: