Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup work to publish chrome-launcher #2251

Closed
samccone opened this issue May 15, 2017 · 11 comments
Closed

Cleanup work to publish chrome-launcher #2251

samccone opened this issue May 15, 2017 · 11 comments
Assignees

Comments

@samccone
Copy link
Contributor

TODO:
7673d15

Also:
Need to figure out how to share log

@paulirish
Copy link
Member

also: make sure the mkdirp type will be exposed to projects consuming LH as a dep
paulirish/pwmetrics#120 (comment)

(should be automatic)

@paulirish
Copy link
Member

Need to figure out how to share log

one answer might be to pull in "debug": "2.2.0", as a dep of c-launcher and use that directly. I think the only gotcha is dealing with loglevel and our --verbose flag, etc?

@pedro93
Copy link

pedro93 commented May 24, 2017

Any update on this?

@samccone
Copy link
Contributor Author

I am working on it now :)

@jooj123
Copy link

jooj123 commented Jun 13, 2017

@samccone any update on this one? Seems to be blocking: paulirish/pwmetrics#120

@ebidel
Copy link
Contributor

ebidel commented Jun 13, 2017

@jooj123, https://github.com/GoogleChrome/lighthouse/pull/2358/files is close. Just a few comments to address.

@samccone
Copy link
Contributor Author

@jooj123 I have been working on this for a while now, a fair amount of work was required to correctly extract this in a non-debt inducing way

#2092

Hope to get this landed quite soon. Thanks

@paulirish
Copy link
Member

Now published on npm as chrome-launcher.

docs: https://github.com/GoogleChrome/lighthouse/tree/master/chrome-launcher

@brendankenny
Copy link
Member

🎉 🎉 🌮 🎉 🎉 🎉 🎉 🎉

@jooj123
Copy link

jooj123 commented Jun 14, 2017

awesome thanks guys 🎉

@ebidel
Copy link
Contributor

ebidel commented Jun 14, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants