LHv2 #120

denar90 · 2017-05-16T22:29:24Z

I've done some experiments with hiding TTI, showing TTFI and TTCI. Also integrated stuff with updated chrome launcher

Trace of nytimes

Stil can't make yarn and my fork works, have to manually build stuff in chrome launcher folder.

Also, we have to update the link to new sheets in doc example because of new metrics.

paulirish · 2017-05-17T02:38:42Z

lib/index.ts

+      });
+      this.flags.port = this.launcher.port;
+    } catch(error) {
+      return error;


probably want to do this.launcher.kill() in the catch

paulirish · 2017-05-17T02:38:53Z

lib/index.ts

+      this.launcher = await launch({
+        port: this.flags.port,
+        chromeFlags: this.flags.chromeFlags,
+        handleSIGINT: true


this one is the default so you can omit it.

paulirish · 2017-05-17T02:40:53Z

package.json

@@ -21,7 +21,7 @@
    "charm": "^1.0.2",
    "google-auth-library": "^0.10.0",
    "googleapis": "^16.0.0",
-    "lighthouse": "paulirish/lighthouse#c74ea959",
+    "lighthouse": "denar90/lighthouse#14cd4f5",


you can do

"lighthouse": "canary",

or

"lighthouse": "2.0.0-alpha.6",

pedro93 · 2017-05-17T07:56:09Z

lib/index.ts

@@ -28,15 +26,14 @@ class PWMetrics {
    view: false,
    expectations: false,
    output: false,
-    // @todo remove when new lighthouse version be released, because -https://github.com/GoogleChrome/lighthouse/pull/1778


@paulirish Will there be no way to disable cpu throttling in lighthouse v2?

The flag still present but
In LH v1 disableCpuThrottling is set up as true by default, we wanted it to be false.
In LH v2 disableCpuThrottling is false by default.

yes what @denar90 said. we now have cpu throttling on as a default
and yeah you can easily disable that.

denar90 · 2017-05-17T15:05:23Z

Only thing is left is error after running yarn

> pwmetrics@2.0.2 build /home/travis/build/paulirish/pwmetrics
> tsc

node_modules/lighthouse/chrome-launcher/utils.ts(22,25): error TS7016: Could not find a declaration file for module 'mkdirp'. '/home/travis/build/paulirish/pwmetrics/node_modules/mkdirp/index.js' implicitly has an 'any' type.

I still have to do cd node_modules/lighthouse/chrome-launcher && yarn then it works...

pedro93 · 2017-05-17T15:20:45Z

@paulirish @samccone Can this not be fixed by a postinstall step on lighthouse? I think it makes sense to have for the chrome-launcher and lighthouse-core modules (assuming we need any typescript files)

paulirish · 2017-05-17T15:38:46Z

I still have to do cd node_modules/lighthouse/chrome-launcher && yarn then it works...

yes. good point. noted that here: GoogleChrome/lighthouse#2251 (comment)

agree that it's kinda broken for typescript consuming apps right now.
cc @samccone

Adds chrome-launcher Bumps lighthouse version to v2.1

Updates lighthouse's version to v2.1 Adds chrome-launcher entry

WIP still does not work.

Adds chrome-launcher typing to Pwmetrics.launcher property and methods for type correctness.

pedro93 · 2017-06-14T10:59:27Z

lib/index.ts

-      await this.launcher.run();
-      return this.launcher;
+      return this.launcher = await launch({
+        port: this.flags.port,


this.flags.port is never set is it?

do we have to set default port? I thought chrome launcher has to take care of it...

I'm not sure, that particular line was there from the original PR code, there was a cyclic dependency on ports. I'll take a look soon but from the chrome-launcher docs it should use a default port.

no need to set a default port :)

Tried it locally but I get this:

Error: connect ECONNREFUSED 127.0.0.1:9222 at Object.exports._errnoException (util.js:1026:11) at exports._exceptionWithHostPort (util.js:1049:20) at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1136:14)

Chrome opens a window with a tab but nothing happens.

+1 faced the same issue. Using some other port - works perfectly.
pwmetrics http://example.com --port=8080

If you use a dynamic port (no port flag) you need to use the port value that is passed back from launcher to connect with.

I would be you or lighthouse has 9222 hard coded somewhere that you are not overriding.

Yes we missed that, I added the port to lighthouse. I think it's best let chrome-launcher find an available port and use that to prevent port-in-use errors. @samccone Lighthouse is port-agnostic too right? It should work on any available port correct?

@samccone thx, btw wdyt about @pedro93 idea?

@pedro93 yup chrome-launcher automatically finds an available port and uses that. LH is port agnostic yup.

what's on the branch now is how i'd do it!

Save chrome-launcher auto-generated ports to utilize it when starting lighthouse.

paulirish

I think this is good to go.

denar90 · 2017-06-17T21:10:57Z

@paulirish shouldn't we clean up https://github.com/paulirish/pwmetrics/blob/master/lib/metrics.ts#L25 due to 8519e27 ?

pedro93 · 2017-06-18T10:30:37Z

Because lighthouse v2 no longer has the TTI metric we need to pick a new to calculate the median run. See https://github.com/denar90/pwmetrics/blob/8519e2713987d5ed24af906e3a28fc71e0d421ef/lib/index.ts#L248 and https://github.com/denar90/pwmetrics/blob/8519e2713987d5ed24af906e3a28fc71e0d421ef/lib/index.ts#L253 I've just run into this problem. @paulirish What is the closest metric to TTI now? TTFI? Should we use an older more stable metric instead?

Replaces removed (with lighthouse v2) TTI metric as the metric to obtain the median run. WARNING Uses First Interactive (vBeta) instead, this metric may be unstable.

pedro93 · 2017-06-18T10:44:18Z

Running pwmetrics on https://github.com gives out the following error:

  ✘ Error: Unable to complete run 1 of 1 due to Audit error: The main thread was busy for the entire trace recording. First Interactive requires the main thread to be idle for several seconds. Audit key: first-interactive.

Using lighthouse version 2.1.0 installed globally via npm, with node v.8.0.0 this metric is correctly obtained. I don't think we should merge until we find out why we get this error.

pedro93

test-runner.sh must be updated to work with node versions 7 and 8. Tests that use the TTI metric must be fixed to use the new TTFI metric instead. Perhaps v6 too since thats what travisCI is using, or update travis to only test on node v7.
I agree with @denar90 that https://github.com/paulirish/pwmetrics/blob/master/lib/metrics.ts#L25 must be updated.

denar90 · 2017-06-19T21:22:17Z

Guys, I think we are ready to ship this one 🚢

pedro93 · 2017-06-19T21:56:46Z

Be my guest @denar90 :)

pedro93 · 2017-06-19T22:10:43Z

Should this be pwmetrics v3?

paulirish · 2017-06-19T22:41:49Z

Probably yeah

…

On Jun 19, 2017 3:10 PM, "Pedro Silva" ***@***.***> wrote: Should this be pwmetrics v3? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#120 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACZF_yH5li0_pbs6o6GxVQjAzypAkwhks5sFvHkgaJpZM4NdKH9> .

denar90 · 2017-06-20T06:38:12Z

Sorry, no squash.

denar90 · 2017-06-20T06:52:11Z

Aaaaand published 💥

denar90 added 4 commits May 16, 2017 23:55

update chrome launcher

ce38ea7

show TTFI, TTCI, hide TTI

de7ce54

drop disableCPUthrottling stuff

ae31b7e

LH dep from denar90 fork

658ade0

paulirish reviewed May 17, 2017

View reviewed changes

pedro93 reviewed May 17, 2017

View reviewed changes

denar90 added 3 commits May 17, 2017 13:52

udpate LH dep version, improve launchChrome method

517290e

update docs

88592df

fix tests

a93c83f

paulirish mentioned this pull request May 17, 2017

Cleanup work to publish chrome-launcher GoogleChrome/lighthouse#2251

Closed

use LH 2.0

ab3dbc2

jooj123 mentioned this pull request Jun 13, 2017

Fails to run silently in CI #118

Closed

pedro93 and others added 5 commits June 13, 2017 19:20

Update package.json

e8b3549

Adds chrome-launcher Bumps lighthouse version to v2.1

Update yarn.lock

f889d38

Updates lighthouse's version to v2.1 Adds chrome-launcher entry

Fix chrome-launcher import

81d21ee

WIP still does not work.

Update index.ts

e2e2a81

Adds chrome-launcher typing to Pwmetrics.launcher property and methods for type correctness.

fix launching chrome

c166986

pedro93 reviewed Jun 14, 2017

View reviewed changes

pedro93 and others added 3 commits June 14, 2017 16:21

Use chrome-launcher auto port

ba04408

Save chrome-launcher auto-generated ports to utilize it when starting lighthouse.

get download-chrome.sh via curl

cdd2c40

minors due to chrome-launcher v0.1.3

2f05f9d

denar90 force-pushed the lh-v2 branch from 6d97cba to 2f05f9d Compare June 16, 2017 20:57

paulirish added 2 commits June 16, 2017 16:31

yarn lock: bump launcher to 0.1.3

70443d5

use our own config for LH, skipping image optimization work.

8519e27

paulirish approved these changes Jun 16, 2017

View reviewed changes

Update findMedianRun

17b616b

Replaces removed (with lighthouse v2) TTI metric as the metric to obtain the median run. WARNING Uses First Interactive (vBeta) instead, this metric may be unstable.

pedro93 requested changes Jun 18, 2017

View reviewed changes

denar90 added 3 commits June 19, 2017 23:38

add pauseAfterNetworkQuietMs to lh-config

4b0e0af

fix tests

6c5e6f5

cleanup metrics ids

dae79b5

denar90 changed the title ~~LHv2 wip~~ LHv2 Jun 19, 2017

pedro93 approved these changes Jun 19, 2017

View reviewed changes

denar90 merged commit 5ed7d0f into paulirish:master Jun 20, 2017

This was referenced Jun 20, 2017

Upgrade to latest lighthouse #119

Closed

Fails after 1st run (Win7, v2.0.2) #121

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LHv2 #120

LHv2 #120

denar90 commented May 16, 2017

paulirish May 17, 2017

samccone May 17, 2017

paulirish May 17, 2017

paulirish May 17, 2017

imjul1an May 28, 2017

pedro93 May 17, 2017

denar90 May 17, 2017

paulirish May 17, 2017

denar90 commented May 17, 2017

pedro93 commented May 17, 2017 •

edited

Loading

paulirish commented May 17, 2017

pedro93 Jun 14, 2017

denar90 Jun 14, 2017

pedro93 Jun 14, 2017 •

edited

Loading

samccone Jun 14, 2017

pedro93 Jun 14, 2017

denar90 Jun 14, 2017

samccone Jun 15, 2017

pedro93 Jun 15, 2017

denar90 Jun 15, 2017

paulirish Jun 16, 2017

paulirish left a comment

denar90 commented Jun 17, 2017

pedro93 commented Jun 18, 2017 •

edited

Loading

pedro93 commented Jun 18, 2017

pedro93 left a comment •

edited

Loading

denar90 commented Jun 19, 2017

pedro93 commented Jun 19, 2017

pedro93 commented Jun 19, 2017

paulirish commented Jun 19, 2017 via email

denar90 commented Jun 20, 2017

denar90 commented Jun 20, 2017

LHv2 #120

LHv2 #120

Conversation

denar90 commented May 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

denar90 commented May 17, 2017

pedro93 commented May 17, 2017 • edited Loading

paulirish commented May 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedro93 Jun 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulirish left a comment

Choose a reason for hiding this comment

denar90 commented Jun 17, 2017

pedro93 commented Jun 18, 2017 • edited Loading

pedro93 commented Jun 18, 2017

pedro93 left a comment • edited Loading

Choose a reason for hiding this comment

denar90 commented Jun 19, 2017

pedro93 commented Jun 19, 2017

pedro93 commented Jun 19, 2017

paulirish commented Jun 19, 2017 via email

denar90 commented Jun 20, 2017

denar90 commented Jun 20, 2017

pedro93 commented May 17, 2017 •

edited

Loading

pedro93 Jun 14, 2017 •

edited

Loading

pedro93 commented Jun 18, 2017 •

edited

Loading

pedro93 left a comment •

edited

Loading