Merge pull request #915 from mondain/feedback

Add type check on track to prevent PLI for non-video tracks.

include/rtc/rtcpnackresponder.hpp

@@ -44,7 +44,7 @@ class RTC_CPP_EXPORT RtcpNackResponder final : public MediaHandlerElement {
 		/// Maximum storage size
 		const unsigned maximumSize;
 
-		/// Returnst current size
+		/// Returns current size
 		unsigned size();
 
 	public:

src/rtcpreceivingsession.cpp

@@ -120,7 +120,7 @@ bool RtcpReceivingSession::send(message_ptr msg) {
 
 bool RtcpReceivingSession::requestKeyframe() {
 	pushPLI();
-	return true; // TODO Make this false when it is impossible (i.e. Opus).
+	return true;
 }
 
 void RtcpReceivingSession::pushPLI() {

src/track.cpp

@@ -45,9 +45,12 @@ void Track::setMediaHandler(shared_ptr<MediaHandler> handler) {
 }
 
 bool Track::requestKeyframe() {
-	if (auto handler = impl()->getMediaHandler())
-		return handler->requestKeyframe();
-
+	// only push PLI for video
+	if (description().type() == "video") {
+		if (auto handler = impl()->getMediaHandler()) {
+			return handler->requestKeyframe();
+		}
+	}
 	return false;
 }