Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type check on track to prevent PLI for non-video tracks. #915

Merged
merged 2 commits into from
Jun 25, 2023

Conversation

mondain
Copy link
Contributor

@mondain mondain commented Jun 24, 2023

While looking at where to handle incoming PLI messages, I made the following minor changes:

  • Fix typo in rtcpnackrsponder.hpp
  • Remove irrelevant comment in rtcpreceivingsession.cpp
  • Modify requestKeyframe method to prevent PLI on non-video tracks

@mondain
Copy link
Contributor Author

mondain commented Jun 25, 2023

@paullouisageneau is there a method or callback for a streaming application to catch PLI or FIR coming from the end-point to which they are connected, so that the application can provide a proper response; such as restarting their video encoder?

@paullouisageneau
Copy link
Owner

Thank you for the changes!

There is no callback to catch a PLI, because it would be part of a RtcpSendingSession which is not present in the library for now, meaning the sender application has to handle RTCP messages.

@paullouisageneau paullouisageneau merged commit e420698 into paullouisageneau:master Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants