Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bins_ptr() accessor for cooler::SingleCellFile() #298

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

robomics
Copy link
Contributor

This should've been part of #199.

@robomics robomics added the enhancement New feature or request label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.56%. Comparing base (70a1d2d) to head (1e20e03).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   77.58%   77.56%   -0.02%     
==========================================
  Files         173      173              
  Lines       21222    21225       +3     
  Branches     2310     2310              
==========================================
- Hits        16465    16464       -1     
  Misses       3755     3755              
- Partials     1002     1006       +4     
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 68.01% <100.00%> (-0.01%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 75.92% <100.00%> (+0.07%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit a5ba139 into main Oct 21, 2024
124 of 125 checks passed
@robomics robomics deleted the feature/sclr-bins-ptr branch October 21, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant