fix(compat): improve react version detection

[acgrdumlu]

What:

Why:

How:

Checklist:

• Documentation
• Tests
• Code complete
• Added myself to contributors table
• Followed the commit message format

[kentcdodds]

Looks great! Two things:

1. update the code to be parseFloat instead of ParseFloat (my bad)
2. This is optional, but you can add yourself to the contributors table. Run npm start contributors.add

Thanks!

[kentcdodds]

Whoops! This should be a lower-case p. Sorry about that! So it should be:

if (parseFloat(React.version.slice(0, 4)) >= 15.5) {

[kentcdodds]

Oh, and another bit of feedback, normally when making a pull request, you'll want to fill in the Pull Request description with something useful. Some open source projects (like this one) will even have a template for you to fill out.

[acgrdumlu]

Hi @kentcdodds
I cannot push again after the changes that you want me to.
When I push the codes with this:
git push --set-upstream origin pr/fix-react-version-detection-new
I'm giving this error;
remote: Permission to paypal/glamorous.git denied to acgrdumlu.
fatal: unable to access 'https://github.com/paypal/glamorous.git/': The requested URL returned error: 403

Could you help me about this issue?

[kentcdodds]

cc @vesparny (or anyone else), could you help @acgrdumlu? I'm afraid I don't have time (getting ready for family vacation!)

[atticoos]

Make sure you push to your fork, @acgrdumlu. Sounds like you may be attempting to push to paypal/glamorous

[kwelch]

This is now resolved with the merge of #189, right?

[vesparny]

Yep. Closing