This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
fix(compat): improve react version detection #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 142 142
Branches 36 36
=====================================
Hits 142 142Continue to review full report at Codecov.
|
kentcdodds
approved these changes
Jun 17, 2017
|
Congratulations on your first ever pull request merge. Very well done. Thank you for your contribution! |
|
Congrats @acgrdumlu! 🎉 Keep it up! |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
parseFloat() function added.
Why:
To make the code consistent.
How:
Adding parseFloat() to this line:
(parseFloat(React.version.slice(0, 4)) >= 15.5)Checklist: