chore: upgrade things #244
Conversation
| @@ -1,49 +1,49 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`overriding styles via className 1`] = ` | |||
| .css-13vote6, | |||
There was a problem hiding this comment.
Yay for v2 of jest-glamor-react!
| @@ -1,7 +1,9 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`Typescript expected failures 1`] = ` | |||
| "test/should-fail.test.tsx(10,3): error TS2345: Argument of type '{ fillRule: \\"cat\\"; }' is not assignable to parameter of type 'StyleArgument<SVGProperties, {}, object>'. | |||
| "test/glamorous.test.tsx(175,31): error TS2322: Type 'HTMLDivElement | null' is not assignable to type 'HTMLDivElement'. | |||
There was a problem hiding this comment.
@luke-john, is this correct?
There was a problem hiding this comment.
It's not no. I'm unsure what caused that, none of the dependencies look like they should have impacted this.
It doesn't appear to have occurred on #246 though, if it happens again I'll investigate further.
Also noticed that this test completely fails on windows due to inconstancies with spawnSync :(. I'll hopefully land something in the coming days to resolve this.
There was a problem hiding this comment.
#246 was on master so it didn't have your recent changes.
| @@ -40,10 +39,9 @@ test('can use pre-built glamorous components with css prop', () => { | |||
| const computed = 'background' | |||
| expect( | |||
| render( | |||
| <glamorous.A | |||
| <glamorous.Span | |||
There was a problem hiding this comment.
I've updated this to a Span because at some point, it was realized that A is a SVG element I guess (tada) which means that all valid SVG props can be forwarded to the A tag. This is actually quite unfortunate because we cannot actually tell ahead of time whether an A tag is used within an SVG or not. So when you use the display prop (as we did in this test), we cannot tell whether you want to forward it on or use it as CSS.
Today we forward it on rather than using it as CSS. It looks like this changed 11 days ago in react-html-attributes, and it's causing the display prop to forward instead of be applied as a css value.
Let's deal with this in a separate issue, but I think we may want to reconsider some things around how we handle this...
|
Going to do this with #246 because that'll be easier 🙄 |
What: This updates a bunch of dependencies and things
Why: Just good to keep up to date (and no, I don't want to use greenkeeper)
How:
yarn.lockbecause I've decided that lockfiles aren't good for librariesnpx npm-check -uChecklist: