This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
fix: some built-in components will now get the right props as CSS #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
force-pushed
the
pr/fix-svg-attributes-issue
branch
from
500b2cd to
5ff0b06
Compare
kentcdodds
force-pushed
the
pr/fix-svg-attributes-issue
branch
6 times, most recently
from
284e20c to
0a693fe
Compare
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 142 144 +2
Branches 36 37 +1
=====================================
+ Hits 142 144 +2
Continue to review full report at Codecov.
|
kentcdodds
force-pushed
the
pr/fix-svg-attributes-issue
branch
2 times, most recently
from
6d29fb3 to
646b9fc
Compare
kentcdodds
force-pushed
the
pr/fix-svg-attributes-issue
branch
from
646b9fc to
878819d
Compare
kentcdodds
commented
Jul 25, 2017
| @@ -28,7 +29,15 @@ const isCustomAttribute = RegExp.prototype.test.bind( | |||
| new RegExp(`^(data|aria)-[${ATTRIBUTE_NAME_CHAR}]*$`), | |||
| ) | |||
|
|
|||
| const isSvgTag = tagName => supportedSVGTagNames.indexOf(tagName) !== -1 | |||
| const isSvgTag = tagName => | |||
There was a problem hiding this comment.
Here's the change that fixes the bug.
| @@ -166,37 +166,15 @@ test('style objects can be arrays and glamor will merge those', () => { | |||
| const phoneMediaQuery = '@media (max-width: 640px)' | |||
There was a problem hiding this comment.
Reformatting changes only
| @@ -80,6 +80,7 @@ | |||
| "rollup-plugin-uglify": "^2.0.1", | |||
| "tslint": "^5.4.3", | |||
| "tslint-microsoft-contrib": "^5.0.0", | |||
| "tsutils": "^1.9.1", | |||
There was a problem hiding this comment.
We were getting peerDep warnings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: This adds a check for whether the given
tagNameis an html tag before saying it's svgWhy: closes #245
How: See the code. Also prettier 😒
Checklist: