Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card: Remove Vault Listener Pattern #306

Merged
merged 22 commits into from
Dec 10, 2024
Merged

Card: Remove Vault Listener Pattern #306

merged 22 commits into from
Dec 10, 2024

Conversation

sshropshire
Copy link
Collaborator

@sshropshire sshropshire commented Dec 9, 2024 •
edited
Loading

Summary of changes

  • This PR migrates the CardClient vault flow away from the listener pattern.
  • Migration Guide updates will come in a later PR
  • Users must now balance calls to CardClient.presentAuthChallenge() with calls to CardClient.finishVault() to complete a vault flow
  • This PR is a follow up to the previously merged Card: Remove Approve Order Listener Pattern #305 PR

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire
Remove the need for a context parameter in CardClient.vault.
a3b1bff
@sshropshire
Add Card vault result.
e8df3c1
@sshropshire
Rename CardVaultResult to LegacyCardVaultResult while refactoring.
4c22b84
@sshropshire
Add CardVaultResult success type.
b14c6c8
@sshropshire
Migrate CardClient.vault() method to listener pattern.
3cb4723
@sshropshire
Add CardAuthLauncher completeVaultAuthRequest method.
268f0e9
@sshropshire
Remove CardVaultListener bindings from CardClient.
3aa4b63
@sshropshire
Refactor VaultCardViewModel to use specialized methods for completing…
f2808c5 
… vault browser switch flows.
@sshropshire
Clean up lint errors.
2b639fb
@sshropshire
Fix CardClientUnitTest.
669a190
@sshropshire
Fix broken CardAuthLauncher test.
6047f15
@sshropshire
Remove unecessary imports in CardClientUnitTest.
1743672
@sshropshire
Remove cardClient.completeAuthChallenge() method.
d4ca36c
@sshropshire
Remove CardClient.removeObservers().
7adf14e
@sshropshire
Remove outdated unit tests.
e63ee3d
@sshropshire
Clean up lint errors.
28a197a
@sshropshire
Remove outdated methods in CardAuthLauncher.
d2e94ef
@sshropshire
Remove LegacyCardVaultResult.
bdcdd7f
@sshropshire
Remove obselete CardStatus type.
43e1df2
@sshropshire
Remove unused imports.
a3421c7
@sshropshire
Move SetupTokenInfo out of CardPayments module.
bd9ceed
@sshropshire
Update CHANGELOG.
48bc76c
@sshropshire sshropshire marked this pull request as ready for review December 10, 2024 19:33
@sshropshire sshropshire requested a review from a team as a code owner December 10, 2024 19:33
@sshropshire sshropshire merged commit 898ba06 into main Dec 10, 2024
6 checks passed
@sshropshire sshropshire deleted the card_vault_remove_listener branch December 10, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KunJeongPark KunJeongPark KunJeongPark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshropshire @KunJeongPark