Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card: Remove Vault Listener Pattern #306

Merged
merged 22 commits into from
Dec 10, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
a3b1bff
Remove the need for a context parameter in CardClient.vault.
sshropshire Dec 6, 2024
e8df3c1
Add Card vault result.
sshropshire Dec 6, 2024
4c22b84
Rename CardVaultResult to LegacyCardVaultResult while refactoring.
sshropshire Dec 6, 2024
b14c6c8
Add CardVaultResult success type.
sshropshire Dec 6, 2024
3cb4723
Migrate CardClient.vault() method to listener pattern.
sshropshire Dec 6, 2024
268f0e9
Add CardAuthLauncher completeVaultAuthRequest method.
sshropshire Dec 6, 2024
3aa4b63
Remove CardVaultListener bindings from CardClient.
sshropshire Dec 6, 2024
f2808c5
Refactor VaultCardViewModel to use specialized methods for completing…
sshropshire Dec 6, 2024
2b639fb
Clean up lint errors.
sshropshire Dec 9, 2024
669a190
Fix CardClientUnitTest.
sshropshire Dec 9, 2024
6047f15
Fix broken CardAuthLauncher test.
sshropshire Dec 9, 2024
1743672
Remove unecessary imports in CardClientUnitTest.
sshropshire Dec 9, 2024
d4ca36c
Remove cardClient.completeAuthChallenge() method.
sshropshire Dec 9, 2024
7adf14e
Remove CardClient.removeObservers().
sshropshire Dec 9, 2024
e63ee3d
Remove outdated unit tests.
sshropshire Dec 9, 2024
28a197a
Clean up lint errors.
sshropshire Dec 9, 2024
d2e94ef
Remove outdated methods in CardAuthLauncher.
sshropshire Dec 9, 2024
bdcdd7f
Remove LegacyCardVaultResult.
sshropshire Dec 9, 2024
43e1df2
Remove obselete CardStatus type.
sshropshire Dec 9, 2024
a3421c7
Remove unused imports.
sshropshire Dec 9, 2024
bd9ceed
Move SetupTokenInfo out of CardPayments module.
sshropshire Dec 9, 2024
48bc76c
Update CHANGELOG.
sshropshire Dec 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unecessary imports in CardClientUnitTest.
  • Loading branch information
sshropshire committed Dec 9, 2024
commit 17436724c80da4858903ea605676fb37b3f1142a
Original file line number Diff line number Diff line change
@@ -10,7 +10,6 @@ import com.paypal.android.cardpayments.api.CheckoutOrdersAPI
import com.paypal.android.cardpayments.api.ConfirmPaymentSourceResult
import com.paypal.android.corepayments.OrderStatus
import com.paypal.android.corepayments.PayPalSDKError
import io.mockk.Called
import io.mockk.coEvery
import io.mockk.every
import io.mockk.mockk
@@ -34,8 +33,6 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import strikt.api.expectThat
import strikt.assertions.isNull

@ExperimentalCoroutinesApi
@RunWith(RobolectricTestRunner::class)