Skip to content

cleanup

cleanup #124

GitHub Actions / clippy succeeded Oct 30, 2023 in 0s

clippy

24 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 24
Note 0
Help 0

Versions

  • rustc 1.73.0 (cc66ad468 2023-10-03)
  • cargo 1.73.0 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (cc66ad4 2023-10-03)

Annotations

Check warning on line 68 in pdf/src/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure

warning: redundant closure
  --> pdf/src/build.rs:68:18
   |
68 |             .map(|ops| Content::from_ops(ops));
   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Content::from_ops`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
   = note: `#[warn(clippy::redundant_closure)]` on by default

Check warning on line 749 in pdf/src/object/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression borrows a value the compiler would automatically borrow

warning: this expression borrows a value the compiler would automatically borrow
   --> pdf/src/object/mod.rs:749:21
    |
749 |         Ok(Box::new((&**self).deep_clone(cloner)?))
    |                     ^^^^^^^^^ help: change this to: `(**self)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 592 in pdf/src/object/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
   --> pdf/src/object/mod.rs:592:70
    |
592 |             Primitive::Array(ref parts) => Ok(Primitive::Array(parts.into_iter().map(|p| p.deep_clone(cloner)).try_collect()?)),
    |                                                                      ^^^^^^^^^ help: call directly: `iter`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
    = note: `#[warn(clippy::into_iter_on_ref)]` on by default

Check warning on line 290 in pdf/src/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `old`

warning: unused variable: `old`
   --> pdf/src/build.rs:290:22
    |
290 |         if let Some((old, new)) = self.shared.get(&key) {
    |                      ^^^ help: if this is intentional, prefix it with an underscore: `_old`

Check warning on line 105 in pdf/src/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `cloner`

warning: unused variable: `cloner`
   --> pdf/src/encoding.rs:105:26
    |
105 |     fn deep_clone(&self, cloner: &mut impl pdf::object::Cloner) -> Result<Self> {
    |                          ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner`

Check warning on line 267 in pdf/src/primitive.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `update`

warning: unused variable: `update`
   --> pdf/src/primitive.rs:267:28
    |
267 |     fn to_primitive(&self, update: &mut impl Updater) -> Result<Primitive> {
    |                            ^^^^^^ help: if this is intentional, prefix it with an underscore: `_update`

Check warning on line 756 in pdf/src/object/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `cloner`

warning: unused variable: `cloner`
   --> pdf/src/object/mod.rs:756:38
    |
756 |                 fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> {
    |                                      ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner`
...
763 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rect, u8, Arc<[u8]>, Vec<u16>);
    | ------------------------------------------------------------------------------------------------- in this macro invocation
    |
    = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 85 in pdf/src/object/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `range`

warning: unused variable: `range`
  --> pdf/src/object/mod.rs:85:41
   |
85 |     fn stream_data(&self, id: PlainRef, range: Range<usize>) -> Result<Arc<[u8]>> {
   |                                         ^^^^^ help: if this is intentional, prefix it with an underscore: `_range`

Check warning on line 85 in pdf/src/object/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `id`

warning: unused variable: `id`
  --> pdf/src/object/mod.rs:85:27
   |
85 |     fn stream_data(&self, id: PlainRef, range: Range<usize>) -> Result<Arc<[u8]>> {
   |                           ^^ help: if this is intentional, prefix it with an underscore: `_id`

Check warning on line 208 in pdf/src/object/function.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `cloner`

warning: unused variable: `cloner`
   --> pdf/src/object/function.rs:208:26
    |
208 |     fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> {
    |                          ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner`

Check warning on line 182 in pdf/src/object/function.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `update`

warning: unused variable: `update`
   --> pdf/src/object/function.rs:182:28
    |
182 |     fn to_primitive(&self, update: &mut impl Updater) -> Result<Primitive> {
    |                            ^^^^^^ help: if this is intentional, prefix it with an underscore: `_update`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 84 in pdf/src/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`Rect` is ambiguous

warning: `Rect` is ambiguous
  --> pdf/src/build.rs:84:31
   |
84 |         self.media_box = Some(Rect {
   |                               ^^^^ ambiguous name
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095>
   = note: ambiguous because of multiple glob imports of a name in the same module
note: `Rect` could refer to the struct imported here
  --> pdf/src/build.rs:15:5
   |
15 | use crate::object::*;
   |     ^^^^^^^^^^^^^^^^
   = help: consider adding an explicit import of `Rect` to disambiguate
note: `Rect` could also refer to the struct imported here
  --> pdf/src/build.rs:16:5
   |
16 | use crate::content::*;
   |     ^^^^^^^^^^^^^^^^^
   = help: consider adding an explicit import of `Rect` to disambiguate

Check warning on line 27 in pdf/src/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`Rect` is ambiguous

warning: `Rect` is ambiguous
  --> pdf/src/build.rs:27:26
   |
27 |     pub trim_box: Option<Rect>,
   |                          ^^^^ ambiguous name
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095>
   = note: ambiguous because of multiple glob imports of a name in the same module
note: `Rect` could refer to the struct imported here
  --> pdf/src/build.rs:15:5
   |
15 | use crate::object::*;
   |     ^^^^^^^^^^^^^^^^
   = help: consider adding an explicit import of `Rect` to disambiguate
note: `Rect` could also refer to the struct imported here
  --> pdf/src/build.rs:16:5
   |
16 | use crate::content::*;
   |     ^^^^^^^^^^^^^^^^^
   = help: consider adding an explicit import of `Rect` to disambiguate

Check warning on line 26 in pdf/src/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`Rect` is ambiguous

warning: `Rect` is ambiguous
  --> pdf/src/build.rs:26:26
   |
26 |     pub crop_box: Option<Rect>,
   |                          ^^^^ ambiguous name
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095>
   = note: ambiguous because of multiple glob imports of a name in the same module
note: `Rect` could refer to the struct imported here
  --> pdf/src/build.rs:15:5
   |
15 | use crate::object::*;
   |     ^^^^^^^^^^^^^^^^
   = help: consider adding an explicit import of `Rect` to disambiguate
note: `Rect` could also refer to the struct imported here
  --> pdf/src/build.rs:16:5
   |
16 | use crate::content::*;
   |     ^^^^^^^^^^^^^^^^^
   = help: consider adding an explicit import of `Rect` to disambiguate

Check warning on line 25 in pdf/src/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`Rect` is ambiguous

warning: `Rect` is ambiguous
  --> pdf/src/build.rs:25:27
   |
25 |     pub media_box: Option<Rect>,
   |                           ^^^^ ambiguous name
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095>
   = note: ambiguous because of multiple glob imports of a name in the same module
note: `Rect` could refer to the struct imported here
  --> pdf/src/build.rs:15:5
   |
15 | use crate::object::*;
   |     ^^^^^^^^^^^^^^^^
   = help: consider adding an explicit import of `Rect` to disambiguate
note: `Rect` could also refer to the struct imported here
  --> pdf/src/build.rs:16:5
   |
16 | use crate::content::*;
   |     ^^^^^^^^^^^^^^^^^
   = help: consider adding an explicit import of `Rect` to disambiguate
   = note: `#[warn(ambiguous_glob_imports)]` on by default

Check warning on line 5 in pdf/src/any.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Object`

warning: unused import: `Object`
 --> pdf/src/any.rs:5:21
  |
5 | use crate::object::{Object};
  |                     ^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check warning on line 755 in pdf_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> pdf_derive/src/lib.rs:755:25
    |
755 |     let (impl_generics, mut ty_generics, where_clause) = generics.split_for_impl();
    |                         ----^^^^^^^^^^^
    |                         |
    |                         help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

Check warning on line 457 in pdf_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `f`

warning: unused variable: `f`
   --> pdf_derive/src/lib.rs:457:85
    |
457 |                 let labels: Vec<Ident> = fields.unnamed.iter().enumerate().map(|(i, f)| {
    |                                                                                     ^ help: if this is intentional, prefix it with an underscore: `_f`

Check warning on line 273 in pdf_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `attrs`

warning: unused variable: `attrs`
   --> pdf_derive/src/lib.rs:273:9
    |
273 |     let attrs = GlobalAttrs::from_ast(ast);
    |         ^^^^^ help: if this is intentional, prefix it with an underscore: `_attrs`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 99 in pdf_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `punctuated::Punctuated`, `token::Where`

warning: unused imports: `punctuated::Punctuated`, `token::Where`
  --> pdf_derive/src/lib.rs:99:14
   |
99 | use syn::{*, punctuated::Punctuated, token::Where};
   |              ^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Check warning on line 755 in pdf_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> pdf_derive/src/lib.rs:755:25
    |
755 |     let (impl_generics, mut ty_generics, where_clause) = generics.split_for_impl();
    |                         ----^^^^^^^^^^^
    |                         |
    |                         help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

Check warning on line 457 in pdf_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `f`

warning: unused variable: `f`
   --> pdf_derive/src/lib.rs:457:85
    |
457 |                 let labels: Vec<Ident> = fields.unnamed.iter().enumerate().map(|(i, f)| {
    |                                                                                     ^ help: if this is intentional, prefix it with an underscore: `_f`

Check warning on line 273 in pdf_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `attrs`

warning: unused variable: `attrs`
   --> pdf_derive/src/lib.rs:273:9
    |
273 |     let attrs = GlobalAttrs::from_ast(ast);
    |         ^^^^^ help: if this is intentional, prefix it with an underscore: `_attrs`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 99 in pdf_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `punctuated::Punctuated`, `token::Where`

warning: unused imports: `punctuated::Punctuated`, `token::Where`
  --> pdf_derive/src/lib.rs:99:14
   |
99 | use syn::{*, punctuated::Punctuated, token::Where};
   |              ^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default