Add the locker tab #161
Merged
Add the locker tab #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DreadBoy
suggested changes
May 30, 2021
DreadBoy
suggested changes
Jun 3, 2021
There was a problem hiding this comment.
I took another look at this PR, I'd really like locker_tab.dart to be split into separate widgets, each private method that now renders subtree could be extracted to new Widget, eg. AppsSheet and AppsSheet.showModal, FacesSheet, AppsItem, FacesCard etc.
Otherwise PR looks good and I also saw #162 was merged. 👍
|
Yup, I'm gonna work on that, though it's a little bit of work so be patient :P |
DreadBoy
suggested changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the mockups, leaving a lot of parts as dead ends, to be implemented later (all should be marked with TODO)
Fix #35
Depends on #162