Enhanced blog post media #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice abstraction 🎉 |
|
👍 so does this remove the issue #85 ? |
|
No I don't think so, you might be able to use the same technique though. For example, creating a template for I'll have a look into this and see if possible. |
|
@petertait cool! I can imagine there would be some js stuff still to load in the video elements, as I think theres a check for is mobile. unless we can do a mobile first approach in someway which doesnt require js? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to include images and youtube videos using a single line direct into the blog post's markdown file. Added feature is the ability to also include an option caption which can double up for alt text.
Youtube
New:
{% include youtube.html id="QmAl2cg3C5U" caption="This is an excellent video" %}Current:
<div class="video"><iframe width="532" height="400" src="//www.youtube.com/embed/QmAl2cg3C5U" frameborder="0" allowfullscreen="allowfullscreen"></iframe></div>Image (with caption)
New:
{% include image.html url="/img/posts/2016-05-17-screen-saver/screen.gif" caption="Our Propsboard dashboard in action" %}Current (still works, but without caption):
Thoughts?