Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cors to cli #221

Closed
xenoterracide opened this issue Sep 29, 2020 · 2 comments
Closed

feat: add cors to cli #221

xenoterracide opened this issue Sep 29, 2020 · 2 comments
Labels
feature

Comments

@xenoterracide
Copy link 

    peer: ^0.5.3

 node --version                                                            # services/.../s3-upload -> feature/RS2-1229-s3-upload-schema $
v12.18.3

I'd like to have a --cors flag added to the command line server for security reasons. We have currently written our own custom server, but this is only to add cors options, I'd really like to extend the docker container (or update it's run command in the docker-compose file) instead of implementing our own server build, which is unlikely to get updated.
@afrokick
Copy link
Member

any PR are welcome)

@afrokick
Copy link
Member

There was an issue #196

@afrokick afrokick mentioned this issue Nov 24, 2020
Closed
jonasgloning added a commit that referenced this issue Feb 14, 2023
@jonasgloning
feat: specify cors options via cli or js
05f12cd 
Closes #196, #221
github-actions bot pushed a commit that referenced this issue Feb 14, 2023
@semantic-release-bot @jonasgloning
chore(release): 1.0.0-rc.10 [skip ci]
d6b5d16 
# [1.0.0-rc.10](v1.0.0-rc.9...v1.0.0-rc.10) (2023-02-14)

### Features

* set the PEERSERVER_PATH with an environment variable ([084fb8a](084fb8a)), closes [#213](#213)
* set the PORT with an environment variable ([68a3398](68a3398)), closes [#213](#213)
* specify cors options via cli or js ([05f12cd](05f12cd)), closes [#196](#196) [#221](#221)
@peerjs-bot
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@peers peers locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xenoterracide @afrokick @peerjs-bot