Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable route on dockerfile #213

Closed
ericwooley opened this issue Aug 28, 2020 · 4 comments
Closed

Configurable route on dockerfile #213

ericwooley opened this issue Aug 28, 2020 · 4 comments
Labels
released on @rc released

Comments

@ericwooley
Copy link

ericwooley commented Aug 28, 2020 •
edited
Loading

I have a suggestion:

I am setting up a peerjs server, and am planning to use the docker image. However, /myApp isn't a good route choice for me. It would be nice to set that with an environment variable. As it is now I need to over ride the cmd.
@NitroLine
Copy link

NitroLine commented Sep 26, 2022 •
edited
Loading

You can change this by changing --path param in CLI using docker-compose command field
You can also add a SSL to your server.

version: '3.7'

services:
  peerjs:
    image: peerjs/peerjs-server:0.6.1
    command: --port 9000 --path /your_path_here --cors --sslkey /var/ssl/privkey.pem --sslcert /var/ssl/fullchain.pem
    container_name: peerjs_server
    expose:
      - 9000
    ports:
      - "9000:9000"
    volumes:
      - ./nginx/certs:/var/ssl

jonasgloning added a commit that referenced this issue Feb 14, 2023
@jonasgloning
feat: set the PEERSERVER_PATH with an environment variable
084fb8a 
Closes #213
@jonasgloning
Copy link
Member

The default has been changed to '/' in the next version (v1.0).
You can then also set the path using the PEERSERVER_PATH variable.

github-actions bot pushed a commit that referenced this issue Feb 14, 2023
@semantic-release-bot @jonasgloning
chore(release): 1.0.0-rc.10 [skip ci]
d6b5d16 
# [1.0.0-rc.10](v1.0.0-rc.9...v1.0.0-rc.10) (2023-02-14)

### Features

* set the PEERSERVER_PATH with an environment variable ([084fb8a](084fb8a)), closes [#213](#213)
* set the PORT with an environment variable ([68a3398](68a3398)), closes [#213](#213)
* specify cors options via cli or js ([05f12cd](05f12cd)), closes [#196](#196) [#221](#221)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0-rc.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Mar 7, 2023
@semantic-release-bot @jonasgloning
chore(release): 1.0.0 [skip ci]
eb6b280 
# [1.0.0](v0.6.1...v1.0.0) (2023-03-07)

### Bug Fixes

* **deps:** update dependency ws to v8 ([1ecc94b](1ecc94b))
* import from ESM only environments ([476299e](476299e))
* more accurate types ([68f973a](68f973a)), closes [#182](#182)
* **npm audit:** Updates all dependencies that cause `npm audit` to issue a warning ([1aaafbc](1aaafbc)), closes [#287](#287)
* the server could crash if a client sends invalid frames ([29394de](29394de))

### Features

* drop Node {10,11,12,13} support ([b70ed79](b70ed79))
* ESM support ([2b73b5c](2b73b5c))
* remove deprecated XHR fallback ([d900145](d900145))
* set the PEERSERVER_PATH with an environment variable ([084fb8a](084fb8a)), closes [#213](#213)
* set the PORT with an environment variable ([68a3398](68a3398)), closes [#213](#213)
* specify cors options via cli or js ([05f12cd](05f12cd)), closes [#196](#196) [#221](#221)

### Performance Improvements

* use the builtin UUID generator for Peer ids instead of the `uuid` module ([5d882dd](5d882dd))

### BREAKING CHANGES

* Requires PeerJS >= 1.0
* Node >= 14 required

14 is the oldest currently supported version. See https://github.com/nodejs/release#release-schedule
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @rc released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ericwooley @jonasgloning @NitroLine