Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there typescript support? #182

Closed
volkans80 opened this issue Apr 20, 2020 · 4 comments
Closed

Is there typescript support? #182

volkans80 opened this issue Apr 20, 2020 · 4 comments
Labels
bug released on @rc released

Comments

@volkans80
Copy link

Hello,

I have a project that uses express with typescript and when i try to use peer server typescript gives error. Peer server class name is CustomExpress and app.use method of express don't accept it as a parameter.

Thanks,

app.use('/peerjs', peerServer);
@afrokick
Copy link
Member

could you please provide a test repo?

@volkans80
Copy link
Author

https://github.com/volkans80/PeerServerTypeScriptTest

When you delete //@ts-ignore in app.ts you get error

image

@volkans80 volkans80 changed the title Is there a typescript support? Is there typescript support? May 16, 2020
@afrokick afrokick added the bug label Nov 24, 2020
github-actions bot pushed a commit that referenced this issue Jan 9, 2023
@semantic-release-bot @jonasgloning
chore(release): 1.0.0-rc.5 [skip ci]
2bbb21f 
# [1.0.0-rc.5](v1.0.0-rc.4...v1.0.0-rc.5) (2023-01-09)

### Bug Fixes

* more accurate types ([68f973a](68f973a)), closes [#182](#182)

### Features

* ESM support ([2b73b5c](2b73b5c))
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

🎉 This issue has been resolved in version 1.0.0-rc.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Mar 7, 2023
@semantic-release-bot @jonasgloning
chore(release): 1.0.0 [skip ci]
eb6b280 
# [1.0.0](v0.6.1...v1.0.0) (2023-03-07)

### Bug Fixes

* **deps:** update dependency ws to v8 ([1ecc94b](1ecc94b))
* import from ESM only environments ([476299e](476299e))
* more accurate types ([68f973a](68f973a)), closes [#182](#182)
* **npm audit:** Updates all dependencies that cause `npm audit` to issue a warning ([1aaafbc](1aaafbc)), closes [#287](#287)
* the server could crash if a client sends invalid frames ([29394de](29394de))

### Features

* drop Node {10,11,12,13} support ([b70ed79](b70ed79))
* ESM support ([2b73b5c](2b73b5c))
* remove deprecated XHR fallback ([d900145](d900145))
* set the PEERSERVER_PATH with an environment variable ([084fb8a](084fb8a)), closes [#213](#213)
* set the PORT with an environment variable ([68a3398](68a3398)), closes [#213](#213)
* specify cors options via cli or js ([05f12cd](05f12cd)), closes [#196](#196) [#221](#221)

### Performance Improvements

* use the builtin UUID generator for Peer ids instead of the `uuid` module ([5d882dd](5d882dd))

### BREAKING CHANGES

* Requires PeerJS >= 1.0
* Node >= 14 required

14 is the oldest currently supported version. See https://github.com/nodejs/release#release-schedule
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released on @rc released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@volkans80 @afrokick