Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pelias Parser to 1.56.1 #1483

Closed
wants to merge 1 commit into from
Closed

Update Pelias Parser to 1.56.1 #1483

wants to merge 1 commit into from

Conversation

orangejulius
Copy link
Member

@orangejulius orangejulius commented Aug 10, 2020 •
edited
Loading

Improvements include:

@orangejulius orangejulius marked this pull request as draft August 10, 2020 16:59
@orangejulius orangejulius marked this pull request as ready for review August 12, 2020 18:08
@orangejulius
Copy link
Member Author

I did some testing of this upgrade, just to stay on top of parser changes. There are actually some minor regressions in address parsing, I suspect due to pelias/parser#115? More investigation is needed. It might not matter as much after work like #1484

missinglink
missinglink approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@missinglink missinglink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

Only concern against merging are the reported address regressions.
Do we have one or two examples of these?

@orangejulius
Copy link
Member Author

I just rebased this to keep it up to date with other PRs that have been merged. The only really notable regression is regarding an address with the square road type. It looks like a few characters in between sq and square are now failing.

Joxit
Joxit approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@Joxit Joxit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orangejulius
feat(deps): Update Pelias Parser to 1.56.1
a6ec04d 
Improvements include:
- Better support for Romanian language: pelias/parser#114
- Remove some minor cases of incorrect venue classification in addresses: pelias/parser#115
- Remove "art" as street type: pelias/parser#116
@orangejulius
Copy link
Member Author

Replaced by #1565

@orangejulius orangejulius deleted the pelias-parser-1.56.1 branch October 11, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joxit Joxit Joxit approved these changes

@missinglink missinglink missinglink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orangejulius @missinglink @Joxit