remove "art" as a steet suffix/type #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks queries like "XXX Museum of Art" where "of art" is seen as [alpha] [street_suffix]. I really have never heard this abbreviation in my life, and it's not in the openstreetmap guide to abbreviations: https://wiki.openstreetmap.org/wiki/Name_finder:Abbreviations#English The USPS doesn't even think "artery" is a valid english street name/type: https://pe.usps.com/text/pub28/28apc_002.htm and browsing through OSM I couldn't find any streets named "X Artery" https://www.openstreetmap.org/search?query=artery#map=17/44.92351/-93.41022
|
👍, never heard of |
Joxit
requested changes
Jul 30, 2020
There was a problem hiding this comment.
You should not edit libpostal dictionaries.
Exceptions are stored here : https://github.com/pelias/parser/blob/master/resources/pelias/dictionaries/libpostal/en/
To remove art, add !art in street_types.txt
|
All the occurrences of Artery as suffix in OSM with
|
orangejulius
added a commit
to pelias/api
that referenced
this pull request
Aug 12, 2020
Improvements include: - Better support for Romanian language: pelias/parser#114 - Remove some minor cases of incorrect venue classification in addresses: pelias/parser#115 - Remove "art" as street type: pelias/parser#116
orangejulius
added a commit
to pelias/api
that referenced
this pull request
Aug 25, 2020
Improvements include: - Better support for Romanian language: pelias/parser#114 - Remove some minor cases of incorrect venue classification in addresses: pelias/parser#115 - Remove "art" as street type: pelias/parser#116
orangejulius
added a commit
to pelias/api
that referenced
this pull request
Oct 14, 2020
Improvements include: - Better support for Romanian language: pelias/parser#114 - Remove some minor cases of incorrect venue classification in addresses: pelias/parser#115 - Remove "art" as street type: pelias/parser#116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks queries like "XXX Museum of Art" where "of art" is seen as
[alpha] [street_suffix]. I really have never heard this abbreviation in
my life, and it's not in the openstreetmap guide to abbreviations:
https://wiki.openstreetmap.org/wiki/Name_finder:Abbreviations#English
The USPS doesn't even think "artery" is a valid english street
name/type: https://pe.usps.com/text/pub28/28apc_002.htm
and browsing through OSM I couldn't find any streets named "X Artery" https://www.openstreetmap.org/search?query=artery#map=17/44.92351/-93.41022