Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stats since we stops the use of type #113

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Conversation

Joxit
Copy link
Member

@Joxit Joxit commented Sep 27, 2019

For the supports of ES6, we need to remove the type mapping. We removed the use of types in pelias/model#95 and now, the default value is doc.
This caused the suppression of the statistics when we do import. Instead of the layer, we only have doc=x instead of address=x for OA.

2019-09-18T21:27:28.360Z - info: [dbclient-openaddresses]  paused=false, transient=1, current_length=190, indexed=479421000, batch_ok=958842, batch_retries=0, failed_records=0, doc=479421000, persec=3000

This PR brings statistics back. It will use the layer value instead of the type. I added a fallback on _type just in case.

2019-09-27T09:50:02.852Z - info: [dbclient-openaddresses]  paused=false, transient=0, current_length=441, indexed=21500, batch_ok=43, batch_retries=0, failed_records=0, address=21500, persec=2150

connected to pelias/model#95
connected to pelias/pelias#719

@orangejulius
Copy link
Member

Oh yeah, good catch! Thanks!

@orangejulius orangejulius merged commit 1003f7f into master Sep 27, 2019
@orangejulius orangejulius deleted the joxit/fix-stats branch September 27, 2019 11:15
orangejulius added a commit to pelias/openstreetmap that referenced this pull request Nov 22, 2019
This is a reasonable change but my ulterior motive is to update the
latest Docker images so that it is built with a version of
pelias-dbclient including the fix in
pelias/dbclient#113, allowing proper printing of
stats during import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants