Remove _type field #95
Conversation
orangejulius
force-pushed
the
remove-types
branch
from
8e56039 to
dafcf16
Compare
orangejulius
force-pushed
the
remove-types
branch
from
dafcf16 to
06230a0
Compare
orangejulius
force-pushed
the
remove-types
branch
3 times, most recently
from
1ae1b62 to
e41b134
Compare
|
While it would be really nice to merge this now and cut our schema size down considerably, we should wait until pelias/pelias#461 is complete so that we can set the document name to the new default ( |
|
This PR is old, but we should still merge it eventually. However, before doing so, we will need to fix pelias/pelias#672 (probably by storing the Pelias GID in the Elasticsearch Otherwise, removing our use of the Elasticsearch |
orangejulius
force-pushed
the
remove-types
branch
from
e41b134 to
27d858a
Compare
|
I just did some refreshing of this PR. It's good to go, however we should wait a bit until #121 has had a chance to make its way out. |
orangejulius
force-pushed
the
remove-types
branch
from
27d858a to
89ed83a
Compare
This should have been done as part of pelias/model#95 Looks like maybe greenkeeper missed it?
BREAKING CHANGE: This change will affect the functional tests on most importers Currently, we create numerous elasticsearch types, corresponding to different layers. All the types are identical, so they don't really serve any value. In Elasticsearch 6 [mapping types will go away](https://www.elastic.co/guide/en/elasticsearch/reference/6.2/removal-of-types.html). The sooner we can remove our minimal usage of types, the easier that transition will be. Connects pelias/pelias#719
orangejulius
force-pushed
the
remove-types
branch
from
89ed83a to
4880fd7
Compare
|
Just did some final testing of this PR. It appears to work great, however it's a breaking change as far as the importers are concerned, as many of their functional tests are expecting certain values for the The commit has been updated to be a breaking change, and so this is finally good to merge after over a year! |
After pelias/model#95, and in anticipation of Elasticsearch 6 support, all use of the `_type` property on Elasticsearch documents has to be avoided. This updates the end to end test expectations with the new single document type, and updates some lingering references in the code to the `_type` field.
After pelias/model#95, and in anticipation of Elasticsearch 6 support, all use of the `_type` property on Elasticsearch documents has to be avoided. This updates the end to end test expectations with the new single document type, and updates some lingering references in the code to the `_type` field.
Currently, we create numerous Elasticsearch types, corresponding to different layers. All the types are identical, so they don't really serve any value.
In Elasticsearch 6 mapping types will go away. The sooner we can remove our minimal usage of types, the easier that transition will be.
Its possible that this will give us a performance benefit right away, although it probably won't. It will simplify our code a bit though!
Note: This PR can be merged right away. Later on, we can merge pelias/schema#293 to enforce a single type everywhere.
Connects pelias/pelias#719