Fix multiple hierarchy support #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, despite the code saying that it supports multiple hierarchies, it didn't actually do so. This is because `map_fields_stream` would push multiple records but then the resulting sink in `readData` would overwrite the last record by id. This commit moves the expanding the multiple hierarchies into multiple documents to `peliasDocGenerators`. `map_fields_stream` now just carries along the multiple hierarchies further down the pipeline.
|
Superseded by #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
This does NOT need to be merged immediately for dev builds but it'll be an issue sooner than we think.