Add multiple hierarchy support #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To clarify, this PR does not add multiple hierarchies to a single document, it creates a separate document for each hierarchy. For example, Slavonski Kobaš has 2 hierarchies, one in Croatia and one in Bosnia and Herzegovina. Right now, we just support the one in Bosnia and Herzegovina. In this example, this PR would create separate documents so that there would be 2 results, one for each hierarchy. Some other examples are: |
trescube
force-pushed
the
add-multiple-hierarchy-support
branch
from
522a8ce
to
803866d
Compare
|
LGTM |
|
There were no failures in the acceptance-tests when running this branch on dev, so we are good to go :) |
trescube
force-pushed
the
add-multiple-hierarchy-support
branch
from
803866d
to
d8a1b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOF supports multiple hierarchies per record, but previously, the importer only went with the last hierarchy in the array. In this PR, all hierarchies are supported.
Fixed #39
Supersedes #40
Connected to #2