-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExtractStrict and ExcludeStrict #38
Conversation
I saw the CI errors locally too:
(unrelated to these changes) |
944287b
to
8af5829
Compare
The CI errors are due to recent changes in TypeScript that make it so |
@pelotom seems to fail either way, using different TS versions? |
I pushed a fix to |
ah, there we go, thanks. lmk if the rest looks good when you have time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good except the "Similar to Pick
/OmitStrict
but for types" language... I get the gist of what you're going for but all type operators are "for types". I'm not sure how to rephrase, but personally I would just drop this line because the "Similar to Exclude
/Exclude
but requires..." language is sufficient.
Removed. thought it'd be nice for people unfamiliar with what the difference is between |
…o strictExtractExclude
Thanks! |
what's your publishing schedule for |
Just published. |
Fixes #37
I ran
yarn format
and picked up some changes inpublic.ts
and in theindex.d.ts
.Let me know if I should also include a version number change, or if you do that yourself when publishing.
(First time using
dtslint
, any tips welcome. I tried to do e.g.$ExpectType 'red' | 'green' | 'blue'
fortype PrimaryColors
and it threw errors saying it gotany
instead. maybe this type of thing doesn't work indtslint
or I was using it wrong? edit: maybe i could try the suggestions here: microsoft/dtslint#179 if you want me to add more tests)