Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react, next and typescript #582

Merged
merged 14 commits into from
Apr 2, 2024
Merged

Bump react, next and typescript #582

merged 14 commits into from
Apr 2, 2024

Conversation

AaDalal
Copy link
Contributor

@AaDalal AaDalal commented Feb 10, 2024

This PR upgrades:

  1. React to 18.2.0 (prev 16)
  2. Next.js to 13.2.1 (prev 9)
  3. Typescript to 4.x.x

A few notes

  • As a consequence of bumping react, we also bump styled-components. Styled components with react 18 requires using transient props to avoid accidentally leaking props as HTML attributes. Many of the changes in this PR are related to switching styled components to transient props.
  • I ran PCR, PCP and PCA locally with these changes -- all seems good from a UI perspective

Before we merge this pr, we need to merge #583 that bumps node to 18.

@AaDalal AaDalal changed the title Bump react next Bump react, next, and node Feb 10, 2024
@AaDalal AaDalal changed the title Bump react, next, and node Bump react and next Feb 10, 2024
@AaDalal AaDalal requested a review from esinx February 10, 2024 02:48
@esinx
Copy link
Member

esinx commented Feb 11, 2024

Works fine on my end, let's just make sure that we have the node version PR in sync

@AaDalal AaDalal changed the title Bump react and next Bump react, next and typescript Apr 2, 2024
Copy link
Contributor Author

@AaDalal AaDalal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review 👍

@@ -1,6 +1,6 @@
import React from "react";
import styled from "styled-components";
import { Range } from "rc-slider";
import Slider from "rc-slider";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of rc-slider version bump

@AaDalal AaDalal merged commit 00ee016 into master Apr 2, 2024
11 checks passed
@AaDalal AaDalal deleted the bump-react-next branch April 2, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants