Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node to 18 #583

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Bump node to 18 #583

merged 2 commits into from
Feb 10, 2024

Conversation

AaDalal
Copy link
Contributor

@AaDalal AaDalal commented Feb 10, 2024

Bumps node to 18 (previously used 10 for deployment, <=16 in development)

Note: this PR uses node's --openssl-legacy-provider option, which is the same behavior as in Node <= 16. This is insecure, though, so we should fix this in a separate PR.

@AaDalal AaDalal changed the title Bump node Bump node to 18 Feb 10, 2024
@AaDalal AaDalal requested review from joyliu-q and Clue88 February 10, 2024 02:41
Copy link
Contributor

@joyliu-q joyliu-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AaDalal AaDalal merged commit 1cfbae0 into master Feb 10, 2024
10 checks passed
@AaDalal AaDalal deleted the bump-node branch February 10, 2024 21:24
@AaDalal AaDalal mentioned this pull request Feb 10, 2024
@AaDalal AaDalal restored the bump-node branch February 17, 2024 20:47
@AaDalal AaDalal deleted the bump-node branch February 17, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants