Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: what is PoP, what it can be #12

Merged
merged 4 commits into from
Feb 28, 2024
Merged

feat: what is PoP, what it can be #12

merged 4 commits into from
Feb 28, 2024

Conversation

peppelinux
Copy link
Owner

@peppelinux peppelinux commented Feb 13, 2024 •
edited
Loading

this PR closes #11

fmarino-ipzs
fmarino-ipzs approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@fmarino-ipzs fmarino-ipzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Btw, we are assuming here that the credential for which a Status Attestation is requested has a cryptographic holder-binding. Is this a right assumption? Should we generalize to cases where we have other holder binding mechanisms or even none?

@peppelinux
Copy link
Owner Author

@fmarino-ipzs This pull request addresses a limitation of the current specification. It currently only works with digital credentials that contain holder key binding.

OR13
OR13 requested changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor word changes, ideally we don't need to distinguish "owner" and "subject", and "ownership" and "possession".

@OR13
Apply suggestions from code review
15dbe4a 
Co-authored-by: Orie Steele <orie@or13.io>
peppelinux
peppelinux commented Feb 28, 2024
View reviewed changes
draft-demarco-oauth-status-attestations.md Outdated Show resolved Hide resolved
draft-demarco-oauth-status-attestations.md Outdated Show resolved Hide resolved
draft-demarco-oauth-status-attestations.md Outdated Show resolved Hide resolved
draft-demarco-oauth-status-attestations.md Outdated Show resolved Hide resolved
@peppelinux peppelinux requested a review from OR13 February 28, 2024 14:05
@OR13 OR13 merged commit 0962d68 into main Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarino-ipzs fmarino-ipzs fmarino-ipzs approved these changes

@OR13 OR13 OR13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define Proof of Possession of a Credential
3 participants
@peppelinux @OR13 @fmarino-ipzs