Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed all the comparisons with oauth status list #51

Merged
merged 3 commits into from
May 21, 2024

Conversation

peppelinux
Copy link
Owner

This PR aims to resolve the issue #50

@@ -133,27 +133,23 @@ validity of the Digital Credentials, including their revocation status,
before accepting them.

Wallet Instance:
: The digital Wallet in control of a User, also known as Wallet or Holder.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dind't want to get in conflict about other specifications with different assumptions about what the holder, technically, is.

# Requirements

The general requirements for the implementation of Status Assertion are
listed in this section. The Status Assertion:

- MUST be presented in conjunction with the Digital Credential.
- SHOULD be presented in conjunction with the Digital Credential.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the section below "Considerations About Revocation Verification"

Comment on lines -143 to -147
OAuth Status Lists [@!I-D.looker-oauth-jwt-cwt-status-list] are suitable
for specific scenarios, especially when the Verifier needs to verify the
status of a Digital Credential at a later time after the User has presented the
Digital Credential.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its okay to keep this one in

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the scopes of this PR, the rationale about the status assertion takes out any comparison to Status List.

There are cases where the Verifier only needs
to check the revocation status of a Digital Credential at the time of
presentation, or situations where the Verifier should not be allowed to
presentation, and therefore it should not be allowed to
check the status of a Digital Credential over time due to some privacy constraints,
in compliance with national privacy regulations.

For instance, consider a scenario where a Verifier's repeated access to a
Status List to check the revocation status of a Digital Credential could

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise you need a reference here?

Comment on lines 77 to 83
+-----------------+ +-------------------+
| | Requests Status Assertions | |
| |----------------------------->| |
| Wallet Instance | | Credential Issuer |
| | Status Assertions | |
| |<-----------------------------| |
+-----------------+ +-------------------+

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would help if we have a common base terminology between status list and status attestations, as we are adopted by OAuth WG, we've used Client instead of Wallet and Referenced Token instead of Credential. Happy to negotiate :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this comment, we should use the term client... and explain that wallet's are a common type of client... Ideally we could all share a reference for wallet that disambiguated, hardware, mobile, cloud and virtual wallets.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Client wins, thank you for this.

Consider It done

@peppelinux peppelinux merged commit 7b631bc into main May 21, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all the comparison with Status List in an issue and remove them from the specs
5 participants