Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Status Assertion and Status Assertion Request headers #56

Merged
merged 7 commits into from
May 25, 2024
Merged

fix: Status Assertion and Status Assertion Request headers #56

merged 7 commits into from
May 25, 2024

Conversation

SaraConsoliACN
Copy link
Contributor

@SaraConsoliACN SaraConsoliACN commented May 22, 2024 •
edited by peppelinux
Loading

PR that aims to resolve issues #19 and #39

@SaraConsoliACN SaraConsoliACN added this to the 03 milestone May 22, 2024
@peppelinux
Copy link
Owner

At the current status of this PR it doesn't address well these points:

peppelinux
peppelinux requested changes May 24, 2024
View reviewed changes
Copy link
Owner

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't resolve the issues that it claimed to resolve.

@peppelinux peppelinux changed the title PR that aims to resolve issues #19 e #39 Status Assertion and Status Assertion Request kid header May 24, 2024
@peppelinux peppelinux changed the title Status Assertion and Status Assertion Request kid header fix: Status Assertion and Status Assertion Request headers May 25, 2024
peppelinux
peppelinux approved these changes May 25, 2024
View reviewed changes
Copy link
Owner

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the typ for the status assertion request object and provided a proposl for the kid, did and x5c header parameters

I look forward for @OR13 and @marinaado and @fmarino-ipzs revisions

@OR13
Apply suggestions from code review
25b2276 
Co-authored-by: Orie Steele <orie@or13.io>
@peppelinux peppelinux requested a review from OR13 May 25, 2024 14:34
@peppelinux peppelinux merged commit e2edac4 into peppelinux:main May 25, 2024
1 check passed
@peppelinux peppelinux mentioned this pull request May 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppelinux peppelinux peppelinux approved these changes

@fmarino-ipzs fmarino-ipzs fmarino-ipzs approved these changes

@OR13 OR13 OR13 approved these changes

@marinaado marinaado Awaiting requested review from marinaado

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
02
Development

Successfully merging this pull request may close these issues.
4 participants
@SaraConsoliACN @peppelinux @OR13 @fmarino-ipzs