PMM-12223 added test for the clickhouse version #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test result are local only: |
saikumar-vs
reviewed
Oct 13, 2023
| @@ -60,6 +61,11 @@ def main(): | |||
| verify_command(f"docker exec {pmm_server_docker_container} rpm -qa | grep percona-qan-api2-{args.version}") | |||
| verify_command( | |||
| f"docker exec {pmm_server_docker_container} rpm -qa | grep percona-dashboards-{args.version}") | |||
|
|
|||
| ### PMM-12223 - Verify Clickhouse is v22.8 or later since 2.41.0 | |||
There was a problem hiding this comment.
looks like u mean v23.8 in the comment ?
There was a problem hiding this comment.
Actually, no - it's a copy of the Ticket's title: see https://jira.percona.com/browse/PMM-12223
But I suppose you're right and I will change the it be more accurate in the sibling PR: #645
saikumar-vs
approved these changes
Oct 13, 2023
BupycHuk
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please note that test will fail until percona/pmm#2489 will be merged