-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-12223 added test for the clickhouse version #644
Conversation
@@ -60,6 +61,11 @@ def main(): | |||
verify_command(f"docker exec {pmm_server_docker_container} rpm -qa | grep percona-qan-api2-{args.version}") | |||
verify_command( | |||
f"docker exec {pmm_server_docker_container} rpm -qa | grep percona-dashboards-{args.version}") | |||
|
|||
### PMM-12223 - Verify Clickhouse is v22.8 or later since 2.41.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like u mean v23.8 in the comment ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, no - it's a copy of the Ticket's title: see https://jira.percona.com/browse/PMM-12223
But I suppose you're right and I will change the it be more accurate in the sibling PR: #645
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
A minor comment. please feel free to fix and push once PR is merged.
please note that test will fail until percona/pmm#2489 will be merged