Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 migrated PMM container components tests to unittest #645

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

vyarosh
Copy link
Contributor

@vyarosh vyarosh commented Oct 15, 2023

Currently will fail until percona/pmm#2489 will be merged.

could be tested on PMM-12223 FB ex: perconalab/pmm-server-fb:PR-3393-e534bc6
the usage is the same, but unittest output is more informative and all tests are executed:

dd@vbox1:/media/sf_work/PMM/pmm-qa/pmm-tests$ python3 check_uprade.py -v 2.40.0
test_alert_manager_status (__main__.PmmServerComponents) ... ok
test_clickhouse_status (__main__.PmmServerComponents) ... ok
test_clickhouse_version (__main__.PmmServerComponents)
PMM-12223 - Verify Clickhouse is v23.8 or later since 2.41.0 ... skipped 'Since version 2.41.0'
test_dbaas_controller_version (__main__.PmmServerComponents) ... ok
test_grafana_status (__main__.PmmServerComponents) ... ok
test_nginx_status (__main__.PmmServerComponents) ... ok
test_percona_dashboards_version (__main__.PmmServerComponents) ... ok
test_percona_qan_api2_version (__main__.PmmServerComponents) ... ok
test_pmm2_client_version (__main__.PmmServerComponents) ... ok
test_pmm_agent_status (__main__.PmmServerComponents) ... ok
test_pmm_dump_version (__main__.PmmServerComponents) ... ok
test_pmm_managed_status (__main__.PmmServerComponents) ... ok
test_pmm_managed_version (__main__.PmmServerComponents) ... ok
test_pmm_update_version (__main__.PmmServerComponents) ... skipped 'for 2.25.0 only!'
test_postgresql_status (__main__.PmmServerComponents) ... ok
test_qan_api2_status (__main__.PmmServerComponents) ... ok
test_vertamedia_clickhouse_plugin_absent (__main__.PmmServerComponents) ... ok
test_victoria_metrics_alert_status (__main__.PmmServerComponents) ... ok
test_victoria_metrics_version (__main__.PmmServerComponents) ... ok
test_victoriametrics_status (__main__.PmmServerComponents) ... ok

----------------------------------------------------------------------
Ran 20 tests in 3.824s

OK (skipped=2)

@yurkovychv
Copy link
Contributor

looks good
could you also run ami and ovf upgrades?

Copy link
Collaborator

@saikumar-vs saikumar-vs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvements, thanks for working on this.

pmm-tests/check_upgrade.py Show resolved Hide resolved
@vyarosh vyarosh dismissed saikumar-vs’s stale review October 18, 2023 13:13

This change is not required at this time

@vyarosh vyarosh merged commit 465ffae into main Oct 18, 2023
28 of 30 checks passed
@vyarosh vyarosh deleted the PMM-7-migrate-upgrade-test branch October 18, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants