🐛 Fix missing dep in cli package #636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@oclif/command and @oclif/errors resolves percy#635
csi-lk
force-pushed
the
fix/missing-dep-in-cli
branch
from
c36545c
to
76e7e6f
Compare
|
Hey @csi-lk! Thanks for the PR -- we're about to PR a big refactor that removes oclif and also adds support for both pnpm & yarn 2+. I'll leave this open until that PR opens (and then close this one out) |
|
@Robdel12 excellent, I did find myself needing to workaround a few pieces to get it to work with yarn 2 I'll watch this PR for updates to the new version, cheers |
|
This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
Shall we close this @Robdel12 ? 😅 |
|
This should be fixed with #670, but a future PR will add full yarn 2+ compatibility 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #635