🚨 Lint against extraneous dependencies #670
Merged
+53
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all circumstances where it matters in this repo, the extraneous dependencies are guaranteed to be present and resolve to their expected versions. However, to better support Yarn 2+ and any other potential node loaders that might block on this, this eslint rule will help ensure that packages only import from their specific dependencies.
wwilsman
commented
Dec 14, 2021
| let url = percy.address.replace('http', 'ws'); | ||
|
|
||
| if (process.env.__PERCY_BROWSERIFIED__) { | ||
| return new window.WebSocket(url); | ||
| } else { | ||
| let socket = new (require('ws'))(url); | ||
| /* eslint-disable-next-line import/no-extraneous-dependencies */ | ||
| let { default: WebSocket } = await import('ws'); |
There was a problem hiding this comment.
While here, I also switched this to a dynamic import rather than a commonjs require in preparation for a full ES module adaptation in the future (dynamic imports will work in the current commonjs environment)
This was referenced Dec 14, 2021
|
Thanks for the work on this @wwilsman |
|
@hellodave76 If you're on Yarn 2+, you can use a |
|
thanks @wwilsman that worked 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
In all circumstances where it matters in this repo, the extraneous dependencies are guaranteed to be present and resolve to their expected versions. However, to better support Yarn 2+ and any other potential node loaders that might block on this, this eslint rule will help ensure that packages only import from their specific dependencies.
The rule is disabled in tests where it usually complains about other packages in the workspace which are always available during development.
Where utils were being transitively imported through
@percy/coredependencies, are now imported through the@percy/corepackage itself (with help of a recent change re-exporting client's request util).