Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add videosink display driver #27

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Add videosink display driver #27

merged 1 commit into from
Dec 8, 2021

Conversation

hansmi
Copy link
Contributor

@hansmi hansmi commented Dec 1, 2021

The videosink package provides a display driver implementing an HTTP
request handler. Client requests get an initial snapshot of the graphics
buffer and are updated further on every change.

Provides the basic implementation for #26. Still to be done are example code and periph/cmd integration.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #27 (031904a) into main (02831f4) will increase coverage by 0.9%.
The diff coverage is 87.7%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #27     +/-   ##
=======================================
+ Coverage   60.3%   61.2%   +0.9%     
=======================================
  Files         48      53      +5     
  Lines       6453    6672    +219     
=======================================
+ Hits        3893    4085    +192     
- Misses      2425    2446     +21     
- Partials     135     141      +6     
Impacted Files Coverage Δ
videosink/handler.go 82.5% <82.5%> (ø)
videosink/display.go 87.5% <87.5%> (ø)
videosink/writer.go 93.8% <93.8%> (ø)
videosink/encoder.go 100.0% <100.0%> (ø)
videosink/format.go 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02831f4...031904a. Read the comment docs.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Nothing structural, just minutia questions.

.github/workflows/test.yml Outdated Show resolved Hide resolved
videosink/display.go Outdated Show resolved Hide resolved
videosink/display.go Show resolved Hide resolved
videosink/display.go Outdated Show resolved Hide resolved
videosink/display.go Show resolved Hide resolved
videosink/format.go Show resolved Hide resolved
videosink/handler.go Show resolved Hide resolved
videosink/handler.go Outdated Show resolved Hide resolved
videosink/handler.go Outdated Show resolved Hide resolved
videosink/writer.go Show resolved Hide resolved
The videosink package provides a display driver implementing an HTTP
request handler. Client requests get an initial snapshot of the graphics
buffer and are updated further on every change.

Signed-off-by: Michael Hanselmann <public@hansmi.ch>
@maruel maruel merged commit 42ee855 into periph:main Dec 8, 2021
@maruel
Copy link
Member

maruel commented Dec 8, 2021

I decided to merge, let's continue the discussion if we want to rename things a bit before next release. Even then it's not a big deal if we break it while there isn't users yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants