Fix Float16Array constructor for SharedArrayBuffer (#1025)

petamoriken · Aug 13, 2023 · d9190ed · d9190ed
1 parent 3274344
commit d9190ed
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 4 deletions.
diff --git a/src/Float16Array.mjs b/src/Float16Array.mjs
@@ -2,7 +2,7 @@ import { safeIfNeeded, wrap } from "./_util/arrayIterator.mjs";
 import { brand, hasFloat16ArrayBrand } from "./_util/brand.mjs";
 import { convertToNumber, roundToFloat16Bits } from "./_util/converter.mjs";
 import {
- isArrayBuffer,
+ isAnyArrayBuffer,
  isCanonicalIntegerIndexString,
  isNativeBigIntTypedArray,
  isNativeTypedArray,
@@ -259,7 +259,7 @@ export class Float16Array {
 
  if (isFloat16Array(input)) {
  float16bitsArray = ReflectConstruct(NativeUint16Array, [getFloat16BitsArray(input)], new.target);
- } else if (isObject(input) && !isArrayBuffer(input)) { // object without ArrayBuffer
+ } else if (isObject(input) && !isAnyArrayBuffer(input)) { // object without ArrayBuffer, SharedArrayBuffer
  /** @type {ArrayLike<unknown>} */
  let list;
  /** @type {number} */
@@ -310,7 +310,7 @@ export class Float16Array {
  for (let i = 0; i < length; ++i) {
  float16bitsArray[i] = roundToFloat16Bits(list[i]);
  }
- } else { // primitive, ArrayBuffer
+ } else { // primitive, ArrayBuffer, SharedArrayBuffer
  float16bitsArray = ReflectConstruct(NativeUint16Array, arguments, new.target);
  }
 

diff --git a/src/_util/is.mjs b/src/_util/is.mjs
@@ -59,7 +59,7 @@ export function isNativeBigIntTypedArray(value) {
  * @param {unknown} value
  * @returns {value is ArrayBuffer}
  */
-export function isArrayBuffer(value) {
+function isArrayBuffer(value) {
  try {
  ArrayBufferPrototypeGetByteLength(/** @type {any} */ (value));
  return true;
@@ -85,6 +85,14 @@ export function isSharedArrayBuffer(value) {
  }
 }
 
+/**
+ * @param {unknown} value
+ * @returns {value is ArrayBuffer|SharedArrayBuffer}
+ */
+export function isAnyArrayBuffer(value) {
+ return isArrayBuffer(value) || isSharedArrayBuffer(value);
+}
+
 /**
  * @param {unknown} value
  * @returns {value is unknown[]}

diff --git a/test/Float16Array.js b/test/Float16Array.js
@@ -448,6 +448,42 @@ describe("Float16Array", () => {
  const detachedBuffer = detach(new ArrayBuffer(4));
  assert.throws(() => new Float16Array(detachedBuffer), TypeError);
  });
+
+ it("input SharedArrayBuffer", function () {
+ if (typeof SharedArrayBuffer === "undefined") {
+ this.skip();
+ }
+
+ const buffer = new SharedArrayBuffer(8);
+ const uint16 = new Uint16Array(buffer);
+ uint16[0] = 15360;
+ uint16[1] = 15462;
+ uint16[2] = 15565;
+ uint16[3] = 15667;
+
+ const float16_1 = new Float16Array(buffer);
+
+ assert(float16_1.BYTES_PER_ELEMENT === 2);
+ assert(float16_1.buffer === buffer);
+ assert(float16_1.byteOffset === 0);
+ assert(float16_1.byteLength === 8);
+ assert(float16_1.length === 4);
+ assert.equalFloat16ArrayValues(float16_1, [
+ 1,
+ 1.099609375,
+ 1.2001953125,
+ 1.2998046875,
+ ]);
+
+ const float16_2 = new Float16Array(buffer, 2, 2);
+
+ assert(float16_2.BYTES_PER_ELEMENT === 2);
+ assert(float16_2.buffer === buffer);
+ assert(float16_2.byteOffset === 2);
+ assert(float16_2.byteLength === 4);
+ assert(float16_2.length === 2);
+ assert.equalFloat16ArrayValues(float16_2, [1.099609375, 1.2001953125]);
+ });
  });
 
  describe(".from()", () => {